[codex] Trigger prosodic nods from vocal speech timing#28
Closed
meekmachine wants to merge 2 commits into
Closed
Conversation
Owner
Author
|
Closing this draft for now. The current goal is to avoid changing Polyester and first verify whether the prosodic/head-nod animation data should be updated in stored animation data rather than package code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs meekmachine/LoomLarge#697.
This keeps speech-time head nods owned by Polyester's prosodic expression agency. The speech/vocal agency now triggers prosodic start, word-boundary pulses, and stop; the prosodic agency remains responsible for loading, scheduling, fading, and playing the head-nod snippets.
What changed
VocalServiceaccepts aprosodicServicedependency and calls:startTalking()when a sentence/timeline is scheduledpulse(wordIndex)on word boundariesstopTalking()when the speech snippet stops or cleans upTTSServicepasses its optionalprosodicServiceconfig through toVocalService, so Web Speech, SAPI, Azure, and external word-boundary paths can use the same agency bridge.inheritflags instead of dropping them.headNodSmallandheadNodBigspeaking snippets now use inherited AU53/AU54 anchors.AGENTS.mdnow documents that speech-time prosody belongs in Polyester, not LoomLarge call sites.Why
The previous LoomLarge-side nod scheduling was the wrong boundary. LoomLarge should configure/pass agencies. Polyester owns speech timing, prosodic pulse handling, and animation scheduling. This PR fixes the inherited-keyframe issue inside the owning agency path and wires speech timing to that agency.
Validation
npm exec vitest run src/vocal/__tests__/service.test.ts src/animation/__tests__/snippetPreloader.test.ts src/prosodic/__tests__/prosodicService.test.tsnpm run typecheck