fix(validation): convert ASK queries to SELECT for both CM and imported - #442
Open
schivmeister wants to merge 1 commit into
Open
fix(validation): convert ASK queries to SELECT for both CM and imported#442schivmeister wants to merge 1 commit into
schivmeister wants to merge 1 commit into
Conversation
Imported SPARQL test files failed validation because the importer only set `content` (raw file), not `query` (validation query). - Add convert_ask_to_select() to sparql_test_suite/services/data.py - Guard against converting queries that already start with SELECT - Use shared converter in importer for imported SPARQL files - Use shared converter in CM assertions (replaces duplicate template calls) - Add unit tests for ASK->SELECT conversion edge cases
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #442 +/- ##
===========================================
+ Coverage 55.63% 55.71% +0.07%
===========================================
Files 200 200
Lines 8309 8333 +24
===========================================
+ Hits 4623 4643 +20
- Misses 3686 3690 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
For the record, this has not worked to solve custom SPARQL validation. The queries are not run. Something else must be afoot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imported SPARQL test files failed validation because the importer only set
content(raw file), notquery(validation query).