Repository navigation
docs(#1866): credit five missing issue authors - #1869
Conversation
Refs #1866 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
me2resh
left a comment
There was a problem hiding this comment.
APPROVED. All four acceptance criteria of #1866 are met, and the five handles are real issue authors. Next action: the human approver does the per-PR merge approval.
Code Review: PR #1869
Commit: cbabebeee7ea75af3776f2ff15b6fe3a782deece
Scope: Full
Summary
The PR adds five entries to "### Issue contributors" in README.md: abbaseya, mahmoudsobhy74, samahali, YOoOUNiieeSS, ZiadHosny. The PR has one commit. Its parent is the PR base bcf3e78a. The diff is 5 insertions and 0 deletions in README.md only. The diff is small. I did a full pass, because no trusted tier result was supplied for a reduced-scope pass.
Acceptance Criteria
| Issue | Criterion | Status | Evidence |
|---|---|---|---|
| #1866 | All five handles appear in "Issue contributors" with the same link and image form as the other entries. | Met | Each added line is identical to the template that the existing entries use (issue search link, title, <handle>.png?size=100 avatar, width="64" height="64", alt). A string comparison of each added line against that template gave 5 of 5 matches. |
| #1866 | The list stays in case-insensitive alphabetical order. | Met | I extracted the 63 handles in the section at head. A case-insensitive sort check (sort -f -c) passed. No duplicate handles. Positions: abbaseya after a-elnemr; mahmoudsobhy74 after mabdelaziz77; samahali after Ref34t; YOoOUNiieeSS after yehiagamalx; ZiadHosny after zeyadsleem. |
| #1866 | No other line in README.md changes. |
Met | git diff --stat of head against its parent: README.md, 5 insertions, 0 deletions. The forge reports 1 changed file. |
| #1866 | Markdown lint passes. | Met | CI check markdownlint-cli2 passed on this head. |
Checklist Results
- Architecture & Design: N/A — docs-only diff, no code.
- Code Quality: N/A — docs-only diff, no code.
- Testing: N/A — no code. The PR body gives the stat, sort, and lint evidence. My checks agree with it.
- Security: N/A — no secrets, no executable content. The avatar and link URLs point only to
github.com. - Performance: N/A — docs-only diff.
- PR Description & Glossary: ✅ Pass — clear summary,
Refs #1866links the ticket, and the Glossary defines "Issue contributor". The body has no closing keyword and no claude.ai URL. - Summary Bullet Narrative: ✅ Pass — each bullet has a verb and states the change.
- Technical Decisions (AgDR): N/A — no technical decision.
- Adopter Handbooks: N/A — docs-only bookkeeping change. No architecture, language, or migration path matches.
- Fallow Static Analysis (JS/TS): N/A — no JS or TS files.
Issues Found
None.
Validation
- Handle check: an issue search by author in
me2resh/apexyardreturned issues for each handle.abbaseya: #1698.mahmoudsobhy74: #1738, #1739, #1744.samahali: #1757, #1758, #1759.YOoOUNiieeSS: #1836.ZiadHosny: #1743, #1745. - Template check: 5 of 5 added lines match the exact entry template.
- Order check:
sort -f -cpassed on the 63 handles at head. No duplicates. - Scope check: head against parent changes
README.mdonly, 5 insertions, 0 deletions. - CI (one read, head
cbabebee): CodeQL, Analyze (actions), hook test suite, Verify Ticket ID, markdownlint-cli2, records-lint, and tier passed. nightly-failure, conformance, and the hook tests matrix were skipped. None failed or was pending. - Limit: I did not view the rendered README. The avatar images load from GitHub at render time.
Verdict
APPROVED
All acceptance criteria are met, each handle is a real issue author, and CI is green. There are no blocking findings.
🤖 Reviewed by Rex (Code Reviewer Agent)
📌 Reviewed commit: cbabebeee7ea75af3776f2ff15b6fe3a782deece
## Summary - **Releases v5.10.1** — see CHANGELOG section below for the full list of changes included in this release - **CHANGELOG.md updated** — new section prepended at the top with the grouped entries and PR refs - **Auto-tag on merge** — `.github/workflows/auto-tag-on-release-pr-merge.yml` will tag the squash commit on main and create a GitHub Release entry automatically when this PR merges (AgDR-0076) - **Release provenance recorded** — a `Released-From` trailer captures the exact `dev` SHA this release was cut from, so the next release's changelog range is deterministic instead of inferred (AgDR-0094, #872) ## CHANGELOG ## [v5.10.1] — 2026-10-24 Patch release — 4 improvements. ### Changed (refactor / chore / docs) - (#1873) harden the terraform-ci golden-path template — ce979c5 - (#1872) state the hook threat model in SECURITY.md — 953d450 - (#1868) add an after-the-release checklist to /release — f9fd80d - (#1869) credit five missing issue authors — 0024f0f ### Thanks - @SecFathy (Mohammed Fathy) reported the problems that #1872 and #1873 fix. ## Migration script - [x] A no-op migration script `.claude/migrations/v5.10.0-to-v5.10.1.sh` is included, and `docs/upgrading.md`'s "What each migration does" table has a matching row. See `.claude/migrations/README.md`. ## Testing 1. After merge, confirm CI creates tag `v5.10.1` on `main` (check the `auto-tag-on-release-pr-merge` workflow run) 2. Verify `git describe --tags --abbrev=0 upstream/main` returns `v5.10.1` 3. Run `/release-sync v5.10.1` to sync main→dev and prevent squash divergence 4. Verify the squash commit's message carries the trailer: `git log -1 --pretty=format:'%(trailers:key=Released-From,valueonly)' v5.10.1` Refs #1874 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- ## Glossary | Term | Definition | |------|------------| | Squash merge | GitHub merges all commits on the PR branch into a single commit on main; the branch HEAD is discarded and the resulting main tip has a new SHA | | Auto-tag | The `auto-tag-on-release-pr-merge.yml` workflow fires on `pull_request` → `closed` + `merged` for `release/v*` branches, tags `github.sha` (the squash commit), and creates a GitHub Release | | Ancestry guard | `git merge-base --is-ancestor <sha> main` — fails if the tag would not be reachable from main, preventing a mis-placed tag like v2.3.0 | | `/release-sync` | The mandatory follow-up skill that merges main→dev after a squash-merge release, preventing SHA divergence accumulation | | `Released-From` trailer | A git trailer (`Key: value` in the commit message's final paragraph) recording the exact `dev` SHA this release was cut from — `bin/release-changelog.sh` reads it back for the next release's changelog range (AgDR-0094) | Released-From: ce979c5
Summary
README.md:abbaseya,mahmoudsobhy74,samahali,YOoOUNiieeSS,ZiadHosny.Testing
git diff --statshowsREADME.mdonly, 5 insertions.markdownlint README.mdreports no errors.Glossary
me2resh/apexyard.Refs #1866
🤖 Generated with Claude Code