Add methods to retrieve physical device information (continuation) - #138
Merged
Conversation
Use c.get instead of c.execute Use netlink.AttributeEncoder for Attrs
lukas-mbag
force-pushed
the
Supernovatux/main
branch
2 times, most recently
from
October 30, 2025 12:37
0cf42a3 to
5dc8f40
Compare
Contributor
Author
|
After fixing linter issues and errors from merging of the current main, I think this PR can be merged now. I did not change functionality of the original PR, but did remove unnecessary and incomplete Frequency-to-Channel (and vice versa) Functions. Currently the Parsing of the Attributes of the PHY-Messages does not cover all Attributes, but the existing ones can be useful. |
lukas-mbag
marked this pull request as ready for review
November 27, 2025 12:30
SuperQ
reviewed
Jan 1, 2026
SuperQ
approved these changes
Jun 21, 2026
Collaborator
|
Would you mind rebasing this against main? |
Contributor
Author
|
will pick up the topic in the next few days ... |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing the work started in #99 by @Supernovatux
----- original PR Text -----
Based on #17 by @dhduvall. It was very hard to rebase the 7 year old PR. So I created a new one here. Borrows most of the code from the old one.
Additions and changes
Added parsing of VHTCapabilities
Handles VHT MCS and HT MCS.
Uses "golang.org/x/sys/unix" instead of "github.com/mdlayher/wifi/internal/nl80211"
Uses c.get instead of c.execute wherever appropriate in getPHYs()
As this PR includes the first lines of Go code I've written (and copied thanks to dhduvall). This will probably need some review :) Suggestions for improvements are welcome!