New energy axis computation#93
Conversation
…nchanged for repeated calls.
mdebony
left a comment
mdebony
left a comment
There was a problem hiding this comment.
My main comment is on naming. When reviewing the PR it was a bit confusing sometime. The best idea I have right now is to be explicit everywhere, so to no have energy_axis_computation anymore, but a base and an effective. However I agree it's not the best, so if you have better idea, feel free to do it.
| @property | ||
| def energy_axis_computation(self): | ||
| if self.dynamic_energy_axis: | ||
| return self._energy_axis_computation | ||
| else: | ||
| return self.base_energy_axis_computation |
There was a problem hiding this comment.
Would not be simpler to simply initialise self._energy_axis_computation at the same time we initialise self.base_energy_axis_computation
There was a problem hiding this comment.
My idea here is that someone could decide to deactivate the dynamic energy binning after the class init. And my logic for not initialising it at least at the start is that I want it to be easy to know if the dynamic binning was run already.
|
@mdebony what about, for the naming:
|
2 participants
Allows for a different computation and base axis, even with the dynamic energy binning.
Stop overwriting the computation axis with the dynamic one to allow better reuse of the class objects and a posteriori extraction of starting informations.
close #86