Rotate events for more statistics#40
Conversation
|
also this currently gammapy v1.2 |
|
@StFroese This is an interesting feature, but with all the automatic changes from your IDE (I guess), it is very hard to read. Plus, such coding style changes should be discussed in an independent issue. |
|
@gabemery ah sry, if you tell me the code style I can reformat :) |
|
We don't have a defined code style yet, but here you change 1200 lines in total for a feature which is probably significantly less. So could you restart this PR with only your changes, deactivating the automatic reformatting of full files? And starting from the current main? |
For stereoscopic telescopes like MAGIC, it is necessary to create background models for multiple
azimuth bins since the stereo trigger regions in the FoV changes in AltAz for different pointings.
Alternatively, Simone has shown that is possible to take all events in FoVAltAz and rotate them accordingly (see here chapter 14 &13, https://eldorado.tu-dortmund.de/items/e77bd429-1755-4f37-8733-dc7518376320)
This PR applies this idea to the exclusion method by rotating all events to a specific observations (the Az of the observation) and additionally rotating the exclusion region accordingly.
Some things that are still not done:
Also this doesn't feel like the right place where I implemented it. On the one it I think should add it for the OFF data method too and I think this probably be a complete new method. What's your opinions?