Don't leave valid images around if there was an invalid image (#388)#394
Merged
Conversation
The wrapper code validates the image option, throwing if any of its items are invalid. However, it previously did this as part of a loop creating the images, which meant that the paths of images that were created would never reach the cleanup function, and would remain in the virtual filesystem. This moves the validation step to before the file creation step so that no image files are created if the images option contains invalid items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrapper code validates the image option, throwing if any of its items are invalid. However, it previously did this as part of a loop creating the images, which meant that the paths of images that were created would never reach the cleanup function, and would remain in the virtual filesystem.
This moves the validation step to before the file creation step so that no image files are created if the images option contains invalid items.