fix(onboarding): prefill name + terms in the completion flow (can't finish without a name)#379
Merged
Merged
Conversation
When completing the profile from a just-in-time prompt (?continue=1), the wizard form started blank, so the full-profile submit failed validation on the missing name — and would have overwritten the name set at minimal signup with an empty string. Prefill the user's existing name and mark the agreements accepted (they were during minimal entry). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Completing your profile from a just-in-time prompt (
?continue=1, e.g. "Create a library") was blocked: the wizard form starts blank, so the full-profile submit failed validation on a missing name — even though the user already set one at minimal signup. Worse, had it gone through, it would have overwritten the saved name with an empty string.Fix
In the continuation flow, prefill the wizard with the user's existing
nameand mark the community agreements as accepted (they were, during minimal entry). Now the completion screen just needs photo + address, and submitting preserves the name.Independent of #378 (touches
ProfileCreationHandler, notProfileWizard).Verification
tsc+ eslint pass.Ready to merge.
🤖 Generated with Claude Code