Skip to content

chore(onboarding): remove the completeness indicator + caption #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcull merged 1 commit into from
Jul 1, 2026
Merged

chore(onboarding): remove the completeness indicator + caption #378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 0 additions & 58 deletions src/components/ProfileWizard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,6 @@ import { z } from 'zod';

import { brandColors } from '@/theme/brandTokens';

import {
profileCardStatus,
completedCardCount,
type CompletenessKey,
} from './profile-wizard/completeness';
import { canSubmitMinimal } from './profile-wizard/minimalEntry';
import { ProfileCompleteness } from './profile-wizard/ProfileCompleteness';
import { ProfileStep1 } from './profile-wizard/ProfileStep1';
import { ProfileStep2 } from './profile-wizard/ProfileStep2';
import { Wordmark } from './Wordmark';
Expand Down Expand Up @@ -335,34 +328,6 @@ export function ProfileWizard({

const CurrentStepComponent = steps[activeStep]?.component;

// Derive card completeness for the indicator that replaced the stepper.
const pa = watchedValues.parsedAddress;
const cardStatus = profileCardStatus({
// Past the entry step, basics are necessarily done (either completed here
// on step 0, or previously via minimal entry when arriving from a prompt —
// the wizard form is blank in that case, so don't rely on it).
hasBasics:
activeStep > 0 ||
canSubmitMinimal({
name: watchedValues.name ?? '',
agreedToHouseholdGoods: !!watchedValues.agreedToHouseholdGoods,
agreedToTrustAndCare: !!watchedValues.agreedToTrustAndCare,
agreedToCommunityValues: !!watchedValues.agreedToCommunityValues,
agreedToAgeRestrictions: !!watchedValues.agreedToAgeRestrictions,
agreedToTerms: !!watchedValues.agreedToTerms,
}),
hasPhoto:
watchedValues.profilePicture instanceof File ||
Boolean(watchedValues.profilePictureUrl),
hasAddress: Boolean(pa?.address1 && pa?.city && pa?.state && pa?.zip),
});

// What's being filled in on the current screen: basics on step 0; both
// photo and address on the combined completion screen (each checks off
// independently as it's completed).
const currentCardKeys: CompletenessKey[] =
activeStep === 0 ? ['basics'] : ['photo', 'address'];

return (
<Container maxWidth="md" sx={{ py: 4 }}>
<Paper
Expand Down Expand Up @@ -459,29 +424,6 @@ export function ProfileWizard({
</Box>
</Box>

{/* Card completeness — what the library card holds, filling in as you
go (replaces the linear 1-2-3 stepper). */}
<Box sx={{ mb: 4 }}>
<ProfileCompleteness
items={cardStatus}
currentKeys={currentCardKeys}
/>
<Typography
variant="caption"
sx={{
display: 'block',
textAlign: 'center',
mt: 1.5,
color: brandColors.charcoal,
opacity: 0.6,
}}
>
{completedCardCount(cardStatus) < cardStatus.length
? 'You can fill in the rest anytime.'
: 'Your card is all set!'}
</Typography>
</Box>

{/* Form Content */}
<FormProvider {...methods}>
<Box
Expand Down
Loading