feat/fix(onboarding): completeness indicator + copy & close polish (#2-#6) [re-land]#374
Merged
Conversation
- Step 1 header now reinforces the fast-track ('name + a few basics') rather
than 'set up how you'll appear'; subtitle is step-aware.
- Just-in-time complete-profile prompts (lend/borrow/create) name the full
ask (photo AND verified address) so there's no surprise second step.
- Wizard gains a prominent Close affordance that exits back to the app when
it was opened from a just-in-time prompt (no longer trapped, Back only
walked wizard steps).
- Photo-rejection message is warm and on-brand instead of a raw model reason
(raw reason still logged for debugging).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…cator (#2) The linear stepper made minimal-first entry feel like a required 3-step process. Replace it with a completeness indicator that shows the parts of the library card (Name & agreements / Photo / Address) and checks each off as it fills in — so photo/address read as 'add anytime,' not 'mandatory next.' - Pure tested profileCardStatus()/completedCardCount() helpers. - ProfileCompleteness component (done = check, current = filled ring, else hollow), plus a 'you can fill in the rest anytime' caption. - Removed the numbered Stepper + custom step-icon styling. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands the onboarding UX pass that was accidentally merged into the wrong base. PR #373 was stacked on #372's branch and got merged into that branch at 00:53, but #372 had already merged to
mainat 00:28 — so none of #2–#6 ever reachedmain. This PR cherry-picks those two commits ontomain.#2 — Card-completeness indicator replaces the 1-2-3 stepper (Name & agreements / Photo / Address, each checking off as it fills in; "fill in the rest anytime" caption). Numbered stepper + custom step icons removed. Pure tested
profileCardStatus().#3 step-aware Step 1 subtitle. #4 JIT prompts name photo + address (CTA "Finish profile"). #5 prominent Close (X) exits the wizard back to the app when opened from a prompt. #6 friendly photo-rejection copy (raw model reason logged, not shown).
Verification
tsc, eslint, unit tests (profileCardStatus,profileSubmitBlockMessage, capability-copy), andnpm run buildall pass.🤖 Generated with Claude Code