Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A connection check after an intentionally lost save response can consume the full five-second request deadline. The previous five-second assertion could end before the next recovery poll even though the stored save was intact.
Allow recovery assertions to observe the deadline and retry, add a stalled connection-check case, and wait for confirmed marking controls and the injected image failure before continuing those scenarios. Product behavior and request deadlines are unchanged.
Validation: five related recovery tests passed. The new stalled-lookup case fails with the previous five-second assertion budget and passes with the recovery budget. Three final stalled-lookup and image-recovery cases also passed. Required checks run on Linux, macOS, and Windows before merging.