fix: fix building on C++20 - fix removal of shared_ptr.unique - #33
Merged
Conversation
This replaces the removed shared_ptr.unique with .use_count() == 1 See this for the explanation https:// en.cppreference.com/w/cpp/memory/shared_ptr/unique
sbaer
requested changes
Dec 28, 2021
sbaer
left a comment
Member
There was a problem hiding this comment.
This is really hard to read. I would recommend changing this to
if (item->m_mesh_sp.use_count() != 1)
Contributor
Author
Fixed in 71e81b4 |
sbaer
approved these changes
Dec 30, 2021
danielgronlund
pushed a commit
to danielgronlund/opennurbs
that referenced
this pull request
Apr 3, 2024
fix: fix building on C++20 - fix removal of shared_ptr.unique Thanks for the fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the removed shared_ptr.unique with .use_count() == 1
See this for the explanation
https:// en.cppreference.com/w/cpp/memory/shared_ptr/unique
Cherry-picked from #28
shraed_ptr.uniquewithshared_ptr.use_count == 1https://en.cppreference.com/w/cpp/memory/shared_ptr/unique