Skip to content

fix: use unsigned int so that 0xFFFFFFFF can be stored - #32

Open
aminya wants to merge 1 commit into
mcneel:7.xfrom
aminya:0xFFFFFFFF-enum
Open

fix: use unsigned int so that 0xFFFFFFFF can be stored#32
aminya wants to merge 1 commit into
mcneel:7.xfrom
aminya:0xFFFFFFFF-enum

Conversation

@aminya

@aminya aminya commented Dec 3, 2021

Copy link
Copy Markdown
Contributor

Cherry-picked from #28

  • It fixes a bug where 0xFFFFFFFF was being narrowed down to int, which resulted in an error in the Clang compiler. This was fixed by adding unsigned int to the enums:
C:/opennurbs/opennurbs_defines.cpp:2032:8: error: case value evaluates to -1, which cannot be narrowed to type 'unsigned int' [-Wc++11-narrowing]
  case os_all_snaps:     osm = os_all_snaps; break;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant