Rename z_inflate to jk_z_inflate. - #115
Conversation
On Linux the z_inflate symbol gets looked up in openvdb SO. This causes crashes. Renaming the symbol works around the problem.
|
@jesterKing I'll see about making this change in the Rhino source and then propagate it here. Thanks! |
|
@jesterKing - ZLIB is an optional dependency of all OpenVDB components. The documented build steps below treat ZLib as a required dependency. You can disable ZLib using -D USE_ZLIB=OFF if Blosc is also disabled using -D USE_BLOSC=OFF. |
@dalefugier That doesn't work very well official Blender releases, not even looking at Blender builds as generated by the different Linux distributions. As an add-on developer I have no control over how official Blender releases are created nor over how distributions build their OpenVDB, but I can recompile rhino3dm (and by extention OpenNURBS). It would be much more convenient of the symbols were renamed at this level, as it does not affect anything outside of the OpenNURBS garden. |
|
Newer versions of ZLIB also do a better job at hiding symbols. |
|
Thanks for bringing this up Nathan. I'm looking into what it takes to build our libraries on linux with functions not being public by default as this would be more inline with our intentions. If we make this change, I don't think we'll need to change any function names in the code. |
|
As long as there is a workable solution :) |
|
@darbyjohnston - the Rhino 9 WIP uses zlib 1.3.1. |
|
@dalefugier That's good news, last time I asked there weren't any plans to upgrade. |
On Linux the z_inflate symbol gets looked up in
openvdb SO. This causes crashes.
Renaming the symbol works around the problem.
See jesterKing/import_3dm#158 and jesterKing/import_3dm#140