Consolidate dense-stripe wavemaket contract → v6 (supersedes final + Amendment 1)#42
Consolidate dense-stripe wavemaket contract → v6 (supersedes final + Amendment 1)#42mcdigman wants to merge 10 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…Amendment 1) Folds in Amendment 1's ULP carve-out, deletes the metadata over-spec (CD-B), inverts the drop-mechanism preference to mask-based predication, and supersedes the Amendment 1 regime/parity recipe (CD-A'). Removes the standalone amendment file; its content is consolidated into the contract and preserved in this branch's history. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ecf3b1c to
431707e
Compare
8ec8ebc to
c06116c
Compare
|
status · 8 findings · max-severity high PR: unknown/0 · base SHA: unknown · head SHA: Contract Readiness Decision Not ready. The contract is unusually detailed, but several acceptance gates can still be satisfied by an implementation that preserves literal source-level structure while hiding divergent behavior in helpers, tests, or unresolved performance/handoff review paths. Blocking Issues F001 · Compliance loophole · high · high F002 · Missing acceptance criterion · high · high F003 · Blocking ambiguity · high · medium F004 · Missing acceptance criterion · medium · high F005 · Missing interface detail · medium · high F006 · Compliance loophole · medium · medium F007 · Phantom requirement · low · high F008 · Missing interface detail · medium · medium Requirement-To-Verification Matrix
Type And Interface Gaps The contract should state whether QA-Evasion Risks The QA-suppression list is strong. Remaining evasion risks are semantic: hiding divergent logic in helpers, coupling ULP-boundary tests to implementation helpers, and relying on “reported but non-failing” benchmark regressions. Add a required disclosure for any new helper excluded from structural inspection. Malicious-Compliance Scenarios
Phantom / Over-Specification Findings The main phantom requirement is “preserve current variable- The “NamedTuple, numba-compatible object, or equivalent” wording is acceptable flexibility, not a blocker, because the observable aligned-table structure is separately specified. Proposed Contract Amendments Add: Add: Add: Replace the sparse loop-preservation sentence with: Residual Risks Human review is still required for whether the source/IR structure is genuinely GPU-portable. Scientific correctness remains anchored to the existing chirp-agent-report:v2 (metadata)schema: chirp-agent-report:v2
pr: 0
base_sha: unknown
head_sha: c06116c3e2efb181228cde00b4e0c3e9c582b559
agent_role: contract-adversary
resolved_model: gpt-5
orientation: claude-drafted
inputs_considered:
contract_sha256: "de2a2a3f1b4e8a9fd3087d0fe6a98cf54fc5fd3ad48e47b53bedb32cf9d600eb"
status: recommend_changes
human_signoff: pending
findings:
- {id: F001, classification: compliance_loophole, severity: high, confidence: high, blocking: true}
- {id: F002, classification: missing_acceptance_criterion, severity: high, confidence: high, blocking: true}
- {id: F003, classification: blocking_ambiguity, severity: high, confidence: medium, blocking: true}
- {id: F004, classification: missing_acceptance_criterion, severity: medium, confidence: high, blocking: true}
- {id: F005, classification: missing_interface_detail, severity: medium, confidence: high, blocking: true}
- {id: F006, classification: compliance_loophole, severity: medium, confidence: medium, blocking: true}
- {id: F007, classification: phantom_requirement, severity: low, confidence: high, blocking: false}
- {id: F008, classification: missing_interface_detail, severity: medium, confidence: medium, blocking: false}
verification:
- {tool: sed, result: "read contract and shared protocol"}
- {tool: shasum, result: "contract sha256 recorded"}
- {tool: rg, result: "repository symbols spot-checked"} |
PIPELINE_PYTHON was used quoted ("$PIPELINE_PYTHON"), so a multi-word value like 'mamba run -n gstoch-dev python' was exec'd as one command -> 'command not found' (exit 127). Split it into an array (_PY) and expand "${_PY[@]}" at the three call sites. Verified: bash -n passes and resolve runs under the gstoch-dev interpreter.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
blocked_pending_human (revision complete; freeze blocked on the F002 human decision + a design-adversary pass) · 8 findings dispositioned · max-severity high PR: #42 · contract: SummaryRevised the v6 consolidated contract to resolve all eight contract-adversary findings (F001–F008). Seven are fully resolved; F002 is partially resolved with an explicit human decision routed below. No frozen Design Intent (DI-1…DI-4) was changed; the revision closes loopholes and pins interface details. New requirements TR37–TR44 were added with traceability; an in-contract disposition ledger ("PR #42 contract-adversary dispositions (revision r1)") was appended. I am not the approver. This goes next to a contract-design-adversary pass and the human approver; the freeze decision is theirs. Finding disposition ledgerF001 — Compliance loophole (high/high) — Accepted and resolved. F002 — Missing acceptance criterion (high/high) — Accepted and PARTIALLY resolved. Human decision required. F003 — Blocking ambiguity (high/medium) — Accepted and resolved. F004 — Missing acceptance criterion (medium/high) — Accepted and resolved. F005 — Missing interface detail (medium/high) — Accepted and resolved. F006 — Compliance loophole (medium/medium) — Accepted and resolved. F007 — Phantom requirement (low/high) — Accepted and resolved. F008 — Missing interface detail (medium/medium) — Accepted and resolved. Conflicts / rejections of note
Verification performed
Open items for the human / next agent
PR: #42 · base SHA: chirp-agent-report:v2 (metadata)schema: chirp-agent-report:v2
pr: 42
base_sha: c06116c3e2efb181228cde00b4e0c3e9c582b559
head_sha: e98ef6e8863d0bec108c72ee95ffb2f5d7b981fa
agent_role: contract-reviser
resolved_model: claude-opus-4-8
orientation: claude-drafted
inputs_considered:
contract_sha256: "de2a2a3f1b4e8a9fd3087d0fe6a98cf54fc5fd3ad48e47b53bedb32cf9d600eb"
revised_contract_sha256: "fd367fbd447d1284db6c8a82ba5ef6190c8251ee031f2f96f1c9862facefb094"
status: blocked_pending_human
human_signoff: pending
findings:
- {id: F001, classification: compliance_loophole, severity: high, confidence: high, blocking: false}
- {id: F002, classification: missing_acceptance_criterion, severity: high, confidence: high, blocking: true}
- {id: F003, classification: blocking_ambiguity, severity: high, confidence: medium, blocking: false}
- {id: F004, classification: missing_acceptance_criterion, severity: medium, confidence: high, blocking: false}
- {id: F005, classification: missing_interface_detail, severity: medium, confidence: high, blocking: false}
- {id: F006, classification: compliance_loophole, severity: medium, confidence: medium, blocking: false}
- {id: F007, classification: phantom_requirement, severity: low, confidence: high, blocking: false}
- {id: F008, classification: missing_interface_detail, severity: medium, confidence: medium, blocking: false}
verification:
- {tool: shasum, result: "reviewed sha matched de2a2a3f; revised fd367fbd"}
- {tool: read, result: "full contract re-read; intent preserved"} |
|
Correction to the contract-reviser handoff above (F002 authority mis-attribution) In the prior comment I justified not adopting the reviewer's F002 IR-inspection proposal by citing "the maintainer's explicit 'no reliance on fragile compiled-code inspection' decision" and a "standing maintainer decision." That attribution is wrong. Correcting it for the record:
Consequence for F002: my grounds were overstated. The correct position is weaker — the source-level-only choice is a consolidation-authored design decision (authority "this consolidation" + DI-2), which is exactly the kind of choice an adversary is entitled to challenge and does not by itself outrank the reviewer's proposal. I therefore did not adopt the IR-inspection mandate unilaterally (it conflicts with the existing DI-2-aligned choice), but the depth question — is source-level inspection the accepted depth, or must lowered IR be inspected? — is a genuinely open human decision, not something an existing mandate settles. It remains routed to the human in Unresolved Blockers. No other finding disposition changes. The revised contract file has been updated to use the accurate authority wording (F002 ledger row, the disposition note, TR38, and the Unresolved-Blockers item). |
|
Revision r2 — authorized human decision HD-1 applied (F002 fully resolved) · contract-reviser The human maintainer made an authoritative decision (HD-1) that resolves F002 on the merits and reverses my earlier (incorrect) deference to the LLM-drafted "no fragile compiled-code inspection" phrasing. Human decision HD-1 (recorded as authoritative; 2026-06-26)
Rationale the maintainer gave, captured in the contract: the prior "no fragile compiled-code inspection" wording was authored by an LLM of the contract-drafter's own model family — precisely the kind of correlated blind spot the cross-family adversarial review exists to catch, and which it did catch as F002. LLVM IR at frozen toolchain versions is a safe, harder-to-evade target; only machine-dependent compiled bytecode would be unworkably fragile. Contract changes in r2
StatusAll eight PR #42 findings (F001–F008) are now resolved; F002 by human decision HD-1. No frozen Design Intent changed. I remain not the approver — the revision should now go to a contract-design-adversary pass and the human approver for the freeze decision. The revised contract is an uncommitted working-tree change to PR: #42 · base SHA: chirp-agent-report:v2 (metadata)schema: chirp-agent-report:v2
pr: 42
base_sha: c06116c3e2efb181228cde00b4e0c3e9c582b559
head_sha: e98ef6e8863d0bec108c72ee95ffb2f5d7b981fa
agent_role: contract-reviser
resolved_model: claude-opus-4-8
orientation: claude-drafted
inputs_considered:
contract_sha256: "de2a2a3f1b4e8a9fd3087d0fe6a98cf54fc5fd3ad48e47b53bedb32cf9d600eb"
revised_contract_sha256: "2149137155fcfec6be146a3f56bdf7f2c36804cfb5876cfa33dcfdf812300753"
human_decision: "HD-1: LLVM IR divergence-free inspection required; native/PTX excluded"
status: recommend_changes
human_signoff: pending
findings:
- {id: F001, classification: compliance_loophole, severity: high, confidence: high, blocking: false}
- {id: F002, classification: missing_acceptance_criterion, severity: high, confidence: high, blocking: false}
- {id: F003, classification: blocking_ambiguity, severity: high, confidence: medium, blocking: false}
- {id: F004, classification: missing_acceptance_criterion, severity: medium, confidence: high, blocking: false}
- {id: F005, classification: missing_interface_detail, severity: medium, confidence: high, blocking: false}
- {id: F006, classification: compliance_loophole, severity: medium, confidence: medium, blocking: false}
- {id: F007, classification: phantom_requirement, severity: low, confidence: high, blocking: false}
- {id: F008, classification: missing_interface_detail, severity: medium, confidence: medium, blocking: false}
verification:
- {tool: shasum, result: "revised r2 sha 2149137155"}
- {tool: grep, result: "no stale 'IR not required'/'routed to human' phrasing remains"} |
Resolves the eight PR #42 contract-adversary findings against the v6 consolidated contract, then applies authorized human decision HD-1. r1 (F001–F008): - F001/TR37: divergence-free structural test now inspects the aligned fn plus all transitive hot-path helpers; disclosed exclusions limited to validation/ table-construction helpers off the accumulation path. - F003/TR40: aligned/dense ratio >1.10x removes auto-approval (blocked_pending_human). - F004/TR39: ULP-boundary mask computed from the contract formula w/o impl helpers; assert not-all-exempt, >=1 non-boundary cell, report count. - F005/TR41: out-of-supported-domain behavior undefined + docstring-disclosed. - F006/TR42: bounds aligned-table constructor/caches (no waveform-dependent full-band precompute); waveform-independent coeff table permitted. - F007/TR43: removed the "preserve variable-k loop as practical" phantom mechanism. - F008/TR44: wavelet_stripe must be a writable nopython ndarray; no internal copy. r2 (HD-1): - New "Authoritative Human Decisions" section (highest authority, above Design Intent). - TR45: LLVM IR divergence-free inspection now REQUIRED (inspect_llvm at pinned toolchain, bounds-check disabled); native/PTX machine code excluded; IR-extraction unavailability => pending human review. Supersedes the LLM-drafted "no fragile compiled-code inspection" phrasing the cross-family adversary flagged as F002. - F002 reclassified Accepted-and-resolved (HD-1); removed from Unresolved Blockers. Contract-only change; no Design Intent altered. Not yet re-approved (design-adversary + human approver still own the freeze). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Record update: the r2 revision (HD-1 / LLVM IR inspection) is now committed and pushed, no longer a working-tree change. Commit |
numba 0.66.0 (released 2026-07-01) stopped re-exporting the `errors` submodule from the top-level `numba` package, so pyright 1.1.410 flags `numba.errors.TypingError` as reportPrivateImportUsage and the Type Check CI job fails. Import TypingError directly from its defining module (numba.core.errors), which is stable across numba versions and creates no new version floor. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
What this PR does
Replaces the dense-stripe Taylor-time wavelet coaddition contract with a single consolidated v6 at
.contracts/implementation_contract_taylor_time_wavelet_optimized.md, and removes the standalone Amendment 1 (now folded in).Net diff: + v6 contract, − Amendment 1.
Version history preserved in the commit record
The contract's full lineage is back-filled as ordered commits, so the evolution lives in git rather than as untracked working-copy files:
v1 → v2 → v3 → v4 → v5 → final → Amendment 1 (marker) → v6Walk the commits to see each version; the PR's net diff shows only
final + Amendment 1 → v6. This PR is contract-only so the spec can be reviewed and line-commented on its own history, separate from the implementation.Why v6 — defect fixes surfaced by the PR #40 review
wc-field storage list (the perpetual F001 false positive); re-expressed the anti-identity-wrapper intent as a prohibited-mechanism + must-fail test.Also bakes in the Step-0 decisions: GPU-readiness staging intent, in-kernel clamp-and-mask for the derivative-domain guard, and a soft, flagged CPU perf floor.
🤖 Generated with Claude Code