Skip to content

Updated Cerebro Documentation - #1

Open
alvynw wants to merge 7 commits into
mc2-project:masterfrom
alvynw:master
Open

Updated Cerebro Documentation#1
alvynw wants to merge 7 commits into
mc2-project:masterfrom
alvynw:master

Conversation

@alvynw

@alvynw alvynw commented Jun 29, 2021

Copy link
Copy Markdown

Directions rely on pull requests for forked copy of SCALE-MAMBA and emp-agmpc

Comment thread source/setup/setup.rst Outdated
Cerebro has a few core dependencies that need to be setup before it can be used.
We provide a Dockerfile that installs all the dependencies required by Cerebro. Running the Dockerfile will build SCALE-MAMBA and EMP-AGMPC.
* Create the Dockerfile and requirements.txt.
* Dockerfile

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of putting the Dockerfile in the documentation, you can create the file and commit it to the repository. See an example here: https://github.com/opaque-systems/opaque/blob/master/docker/Dockerfile.

Comment thread source/setup/setup.rst Outdated
*************************

Cerebro has a few core dependencies that need to be setup before it can be used.
We provide a Dockerfile that installs all the dependencies required by Cerebro. Running the Dockerfile will build SCALE-MAMBA and EMP-AGMPC.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can simply say "We provide a Dockerfile that installs Cerebro as well as its dependencies."

Comment thread source/setup/setup.rst
Comment on lines -10 to -20
The documentation fully detailing SCALE-MAMBA can be obtained by running ``make doc`` in the SCALE-MAMBA repository.

The following is copied from SCALE-MAMBA's current setup documentation.

Prerequisite Libraries:
*************************
* gcc/g++, tested with version 7.2.1
* MPIR (compiled with the -cxx flag)
* python 2.7.5 (ideally with gmpy2 installed)
* OpenSSL (tested with version 1.1.0)
* Crypto ++ (tested with version 7.0)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these should be commented out? Docker is one way to test out Cerebro, but we need to still provide an installation guide for people who want to install Cerebro from scratch.

Comment thread source/setup/setup.rst


Setup Steps for SCALE-MAMBA
*****************************

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these setup instructions, it would be good to put the instructions in code blocks, instead of in text. This way, a user can just copy and paste the commands into shell and run them.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want text/explanations at all? I can remove the text section if you don't want it. I will add a section that has purely shell commands which will set everything up if copy pasted into the shell. Some commands might be a bit cryptic though.

Comment thread source/setup/setup.rst

EMP-AGMPC
################
Prerequisite Libraries:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should probably be kept as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants