Add support for Sonarqube 26.7 - #1280
gsaraiva2109 wants to merge 3 commits into
Conversation
Bump plugin/build/lib versions to target SonarQube Community Build 26.7.0.124771. Skips 26.6 since no plugin release was ever cut for it. Pins the sonarqube-webapp submodule to the sqcb-26.6.0 tag since SonarSource hasn't published a 26.7 webapp snapshot yet (26.7 is a backend-only release). Also fixes ScannerPullRequestPropertySensorTest, which no longer compiled: SensorContextTester/TestInputFileBuilder were removed from the server distribution in 26.6/26.7. Rewrote it with plain Mockito against SensorContext directly.
|
hi, to fix the QP selection issue, you need this commit from webapp. This is not included in 26.6.0 version of webapp as it has been committed about a week later. |
|
hi, webapp now has the sqcb-26.7.0 tag . I did a quick check and the above mentioned commit for the UI fix is included. |
SonarSource has now tagged a 26.7 webapp snapshot, which includes the QP select dropdown fix (SONAR-27859 / 2ee7b79) that was missing from sqcb-26.6.0. Re-point the submodule to the proper tag instead of the 26.6 stand-in.
Hi, I did update the webpack, now I'm just waiting for the author to code review and merge... |
|
@mc1arke Could you please review this PR? |
|
FYI, in case it is useful: we needed 26.8 (26.8.0.126808) and it turned out to work with the same changes as this PR plus one extra bit — With that, Not asking for anything — just noting that the jump does not seem to require more than a version bump either. Thanks for the plugin. |
|
Heads-up: the The PR description says the submodule was pinned to Cause:
Three files in
Worth noting the addons library already uses a different Spinner elsewhere — Why CI didn't catch it: there are no check runs on Data point on 26.8, corroborating @renatoaraujo above: we're running 26.8 ( Not asking for anything — just flagging that the pin as it stands won't produce a working image. |
sqcb-26.7.0 (and 26.8.0) drop libs/sq-server-commons/src/design-system/ components/Spinner.tsx, which BranchList, BranchPurgeSetting, and LifetimeInformationRenderer still imported from ~design-system, breaking sq-server:build. Switch them to the @sonarsource/echoes-react Spinner already used elsewhere in this addon (BranchNewCodeDefinition- SettingModal, PullRequestOverview), renaming the loading prop to isLoading to match its API. Verified with docker build --target webapp-builder: nx run sq-server: build now completes clean.
|
Good catch, thanks for the detailed writeup. You were right on all counts. Confirmed it locally: Spinner.tsx is gone from design-system as of sqcb-26.7.0 (also checked 26.8.0, still gone there), and BranchList.tsx, BranchPurgeSetting.tsx and LifetimeInformationRenderer.tsx were still pulling it from ~design-system. Just pushed a fix that switches all three to the echoes-react Spinner instead, same one BranchNewCodeDefinitionSettingModal and PullRequestOverview already use, just had to rename the loading prop to isLoading since that's what echoes-react expects. Ran it through docker build --target webapp-builder to make sure nx actually builds sq-server now, and it does. Also agree on the CI point, build-ui never ran on this branch since it's a fork PR and needs to be approved first, that's on the repo side not something I can fix from here. Went with keeping the webapp on 26.7 rather than falling back to 26.6 since 26.7 has the QP fix natively now and this addon fix covers the only thing that was actually broken. |
Closes #1277
Adds support for SonarQube Community Build 26.7 (26.7.0.124771).
Bumped the
sonarqubeVersionin build.gradle, the .env defaults, and gradle.properties dev version. Skipped 26.6 entirely since no plugin release ever went out for it, so this jumps straight from 26.5.1 to 26.7.One thing worth flagging for review: SonarSource hasn't tagged a 26.7 webapp snapshot yet (no
sqcb-26.7.0), and 26.7's release notes are backend-only anyway, so I pinned thesonarqube-webappsubmodule tosqcb-26.6.0instead of leaving it stale or pointing atmaster(which is tracking their internal 2026.x versioning and isn't compatible here).Also had to fix
ScannerPullRequestPropertySensorTest, it wouldn't compile anymore.SensorContextTesterandTestInputFileBuildergot removed from the server distribution somewhere between 26.5 and 26.7. Rewrote it against a mockedSensorContextinstead, same assertions, no changes needed on the production side.Tested locally end to end:
./gradlew clean buildand the full test suite pass, and I ran it against a live 26.7 instance via docker-compose, plugin loads clean on both web and CE, and branch/PR analysis worked in my testing.Happy to re-point the webapp submodule once SonarSource ships a 26.7 tag, if that's preferred over merging with the 26.6 one.