chore: upgrade erlang and elixir versions

.tool-versions

@@ -1,4 +1,4 @@
-elixir 1.17.3-otp-27
-erlang 27.3.4.13
+elixir 1.19.5-otp-28
+erlang 28.5.0.3
 python 3.9.16
 poetry 1.7.0

Dockerfile

@@ -1,5 +1,5 @@
-ARG ELIXIR_VERSION=1.17.3
-ARG ERLANG_VERSION=27.3.4.13
+ARG ELIXIR_VERSION=1.19.5
+ARG ERLANG_VERSION=28.5.0.3
 ARG ALPINE_VERSION=3.21.7
 
 FROM hexpm/elixir:${ELIXIR_VERSION}-erlang-${ERLANG_VERSION}-alpine-${ALPINE_VERSION} as builder

apps/api_accounts/lib/api_accounts.ex

@@ -454,7 +454,7 @@ defmodule ApiAccounts do
   def auto_approve_key?(%User{} = user) do
     # if there are no other keys, approve this one
     user
-    |> list_keys_for_user
+    |> list_keys_for_user()
     |> Enum.empty?()
   end
 

apps/api_accounts/lib/api_accounts/table.ex

@@ -184,19 +184,19 @@ defmodule ApiAccounts.Table do
 
   @doc false
   def __before_compile__(env) do
-    unless Module.get_attribute(env.module, :struct_fields) do
+    if !Module.get_attribute(env.module, :struct_fields) do
       raise ArgumentError,
             "module #{inspect(env.module)} uses ApiAccounts.Table but it " <>
               "does not define a table."
     end
 
-    unless Module.get_attribute(env.module, :primary_key) do
+    if !Module.get_attribute(env.module, :primary_key) do
       raise ArgumentError,
             "module #{inspect(env.module)} uses ApiAccounts.Table but it " <>
               "does not define a primary key. Refer to ApiAccounts.Table.field/3."
     end
 
-    unless Module.get_attribute(env.module, :schema_version) do
+    if !Module.get_attribute(env.module, :schema_version) do
       raise ArgumentError,
             "module #{inspect(env.module)} uses ApiAccounts.Table but it " <>
               "does not define a schema version. Refer to " <>

apps/api_web/lib/api_web/api_controller_helpers.ex

@@ -190,7 +190,7 @@ defmodule ApiWeb.ApiControllerHelpers do
   defp do_filter_valid_field_attributes(conn, {type, fields}) do
     view_module = view_module_for_type(type)
 
-    attr_filter = fn attr -> conn |> view_module.attribute_set |> MapSet.member?(attr) end
+    attr_filter = fn attr -> conn |> view_module.attribute_set() |> MapSet.member?(attr) end
 
     fields
     |> String.split(",")

apps/api_web/lib/api_web/api_view_helpers.ex

@@ -64,7 +64,7 @@ defmodule ApiWeb.ApiViewHelpers do
 
     builder
     |> JaSerializer.Formatter.format()
-    |> log_record_count
+    |> log_record_count()
   end
 
   defp log_record_count(%{"data" => list} = data) when is_list(list) do

apps/api_web/lib/api_web/controllers/admin/accounts/key_controller.ex

@@ -32,7 +32,7 @@ defmodule ApiWeb.Admin.Accounts.KeyController do
     key_params =
       key_params
       |> Map.put(:rate_request_pending, false)
-      |> handle_per_minute
+      |> handle_per_minute()
 
     key = ApiAccounts.get_key!(key_id)
     user = conn.assigns.user

apps/api_web/lib/api_web/controllers/line_controller.ex

@@ -50,7 +50,7 @@ defmodule ApiWeb.LineController do
         case filtered do
           %{"id" => ids} ->
             ids
-            |> split_on_comma
+            |> split_on_comma()
             |> State.Line.by_ids()
 
           _ ->

apps/api_web/lib/api_web/controllers/live_facility_controller.ex

@@ -67,7 +67,7 @@ defmodule ApiWeb.LiveFacilityController do
 
   defp do_index_data(ids, conn, params) do
     ids
-    |> split_on_comma
+    |> split_on_comma()
     |> State.Facility.Parking.by_facility_ids()
     |> Enum.group_by(& &1.facility_id)
     |> Enum.map(fn {facilty_id, properties} ->

apps/api_web/lib/api_web/controllers/schedule_controller.ex

@@ -115,7 +115,7 @@ defmodule ApiWeb.ScheduleController do
   end
 
   def populate_extra_times(map, %{assigns: %{api_version: ver}}) when ver < "2019-07-01" do
-    for s <- map do
+    for %Model.Schedule{} = s <- map do
       s = if s.pickup_type == 1, do: %Model.Schedule{s | departure_time: s.arrival_time}, else: s
       if s.drop_off_type == 1, do: %Model.Schedule{s | arrival_time: s.departure_time}, else: s
     end

apps/api_web/lib/api_web/plugs/modified_since_handler.ex

@@ -102,13 +102,13 @@ defmodule ApiWeb.Plugs.ModifiedSinceHandler do
 
   if Application.compile_env(:api_web, __MODULE__)[:check_caller] do
     defp ensure_caller_defined(opts) do
-      unless opts[:caller] do
+      if !opts[:caller] do
         raise ArgumentError, "expected `:caller` to be provided with module"
       end
     end
 
     defp ensure_state_module_implemented(opts) do
-      unless opts[:caller].module_info(:exports)[:state_module] == 0 do
+      if opts[:caller].module_info(:exports)[:state_module] != 0 do
         raise ArgumentError,
               "expected `:caller` to implement " <>
                 "`state_module/0` and return a module from the " <> "`State` namespace"

apps/api_web/lib/api_web/plugs/validate_date.ex

@@ -14,7 +14,7 @@ defmodule ApiWeb.Plugs.ValidateDate do
 
   def call(%Conn{query_params: query_params} = conn, []) do
     query_params
-    |> get_date
+    |> get_date()
     |> validate_date(conn)
   end
 

apps/api_web/lib/api_web/swagger_helpers.ex

@@ -299,7 +299,7 @@ defmodule ApiWeb.SwaggerHelpers do
   """
   def path(controller, action) do
     controller
-    |> path_fn
+    |> path_fn()
     |> call_path(action)
   end
 
@@ -320,7 +320,7 @@ defmodule ApiWeb.SwaggerHelpers do
 
     short_name =
       module
-      |> to_string
+      |> to_string()
       |> String.split(".")
       |> List.last()
       |> String.replace_suffix("Controller", "")

apps/api_web/lib/api_web/views/facility_view.ex

@@ -51,7 +51,7 @@ defmodule ApiWeb.FacilityView do
       properties =
         facility.id
         |> State.Facility.Property.by_facility_id()
-        |> encode_properties
+        |> encode_properties()
 
       Map.put(attrs, :properties, properties)
     else

apps/api_web/lib/date_helpers.ex

@@ -51,7 +51,7 @@ defmodule DateHelpers do
 
   def add_seconds_to_date(%Date{} = date, seconds) do
     date
-    |> unix_midnight_seconds
+    |> unix_midnight_seconds()
     |> add_seconds_to_date(seconds)
   end
 

apps/api_web/test/api_web/controllers/portal/user_controller_test.exs

@@ -313,7 +313,7 @@ defmodule ApiWeb.Portal.UserControllerTest do
     setup %{conn: conn} do
       {:ok, user_disabled} = ApiAccounts.create_user(%{email: "nofa@example.com"})
 
-      {:ok, conn: conn |> conn_with_session |> conn_with_user(user_disabled)}
+      {:ok, conn: conn |> conn_with_session() |> conn_with_user(user_disabled)}
     end
 
     test "configure 2fa with user with no 2fa", %{conn: conn} do
@@ -385,7 +385,7 @@ defmodule ApiWeb.Portal.UserControllerTest do
           time: time
         )
 
-      {:ok, conn: conn |> conn_with_session |> conn_with_user(user_enabled)}
+      {:ok, conn: conn |> conn_with_session() |> conn_with_user(user_enabled)}
     end
 
     test "configure 2fa with user with 2fa", %{conn: conn} do

apps/api_web/test/api_web/controllers/stop_controller_test.exs

@@ -653,7 +653,10 @@ defmodule ApiWeb.StopControllerTest do
     stop2 = %Stop{id: "2"}
     State.Stop.new_state([stop, stop2])
 
-    State.Route.new_state([%Model.Route{id: "route", type: 2}, %Model.Route{id: "other", type: 4}])
+    State.Route.new_state([
+      %Model.Route{id: "route", type: 2},
+      %Model.Route{id: "other", type: 4}
+    ])
 
     State.Trip.new_state([
       %Model.Trip{id: "trip", route_id: "route", direction_id: 1},

apps/api_web/test/api_web/plugs/deadline_test.exs

@@ -13,7 +13,7 @@ defmodule ApiWeb.Plugs.DeadlineTest do
       assert :ok =
                conn
                |> set(5_000)
-               |> check!
+               |> check!()
     end
 
     test "returns :ok if no deadline was set", %{conn: conn} do

apps/health/lib/health/checker.ex

@@ -9,13 +9,13 @@ defmodule Health.Checker do
 
   def current do
     :current
-    |> each_checker
+    |> each_checker()
     |> Enum.reduce([], &Keyword.merge/2)
   end
 
   def healthy? do
     :healthy?
-    |> each_checker
+    |> each_checker()
     |> Enum.all?()
   end
 

apps/parse/lib/parse/alerts.ex

@@ -27,7 +27,7 @@ defmodule Parse.Alerts do
     for alert <- alert_json(json_map), active?(alert) do
       alert
       |> parse_alert()
-      |> cleanup_description
+      |> cleanup_description()
     end
   end
 
@@ -2712,24 +2712,24 @@ defmodule Parse.Alerts do
       id: Map.get(alert, "id"),
       effect: "PARKING_ISSUE",
       cause: cause(alert),
-      header: alert |> Map.get("header_text") |> translated_text,
-      short_header: alert |> Map.get("short_header_text") |> translated_text,
-      description: alert |> Map.get("description_text") |> translated_text,
+      header: alert |> Map.get("header_text") |> translated_text(),
+      short_header: alert |> Map.get("short_header_text") |> translated_text(),
+      description: alert |> Map.get("description_text") |> translated_text(),
       banner: alert |> Map.get("banner_text") |> translated_text(default: nil),
       severity: Map.get(alert, "severity"),
-      created_at: alert |> Map.get("created_timestamp") |> unix_timestamp,
-      updated_at: alert |> Map.get("last_modified_timestamp") |> unix_timestamp,
+      created_at: alert |> Map.get("created_timestamp") |> unix_timestamp(),
+      updated_at: alert |> Map.get("last_modified_timestamp") |> unix_timestamp(),
       active_period:
         alert
         |> Map.get("active_period", [])
         |> fallback_active_period()
         |> Enum.map(&active_period/1),
       informed_entity:
         Enum.map(Map.get(alert, "informed_entity") ++ added_informed_entities, &informed_entity/1),
-      service_effect: alert |> Map.get("service_effect_text") |> translated_text,
+      service_effect: alert |> Map.get("service_effect_text") |> translated_text(),
       timeframe: alert |> Map.get("timeframe_text") |> translated_text(default: nil),
       duration_certainty: alert |> Map.get("duration_certainty"),
-      lifecycle: alert |> Map.get("alert_lifecycle") |> lifecycle,
+      lifecycle: alert |> Map.get("alert_lifecycle") |> lifecycle(),
       url: alert |> Map.get("url") |> translated_text(default: nil),
       image: alert |> Map.get("image") |> translated_image(default: nil),
       image_alternative_text:
@@ -2746,25 +2746,25 @@ defmodule Parse.Alerts do
       id: Map.get(alert, "id"),
       # Backwards compatability-can change to `translated_text` after all instances of
       # alerts manager are returning a translated string
-      effect: alert |> Map.get("effect_detail") |> maybe_translated_text,
+      effect: alert |> Map.get("effect_detail") |> maybe_translated_text(),
       cause: cause(alert),
-      header: alert |> Map.get("header_text") |> translated_text,
-      short_header: alert |> Map.get("short_header_text") |> translated_text,
-      description: alert |> Map.get("description_text") |> translated_text,
+      header: alert |> Map.get("header_text") |> translated_text(),
+      short_header: alert |> Map.get("short_header_text") |> translated_text(),
+      description: alert |> Map.get("description_text") |> translated_text(),
       banner: alert |> Map.get("banner_text") |> translated_text(default: nil),
       severity: Map.get(alert, "severity"),
-      created_at: alert |> Map.get("created_timestamp") |> unix_timestamp,
-      updated_at: alert |> Map.get("last_modified_timestamp") |> unix_timestamp,
+      created_at: alert |> Map.get("created_timestamp") |> unix_timestamp(),
+      updated_at: alert |> Map.get("last_modified_timestamp") |> unix_timestamp(),
       active_period:
         alert
         |> Map.get("active_period", [])
         |> fallback_active_period()
         |> Enum.map(&active_period/1),
       informed_entity: alert |> Map.get("informed_entity") |> Enum.map(&informed_entity/1),
-      service_effect: alert |> Map.get("service_effect_text") |> translated_text,
+      service_effect: alert |> Map.get("service_effect_text") |> translated_text(),
       timeframe: alert |> Map.get("timeframe_text") |> translated_text(default: nil),
       duration_certainty: alert |> Map.get("duration_certainty"),
-      lifecycle: alert |> Map.get("alert_lifecycle") |> lifecycle,
+      lifecycle: alert |> Map.get("alert_lifecycle") |> lifecycle(),
       url: alert |> Map.get("url") |> translated_text(default: nil),
       image: alert |> Map.get("image") |> translated_image(default: nil),
       image_alternative_text:

apps/parse/lib/parse/stop_times.ex

@@ -57,8 +57,8 @@ defmodule Parse.StopTimes do
   defp parse_rows(rows, nil) do
     rows
     |> Enum.map(&parse_row/1)
-    |> position_first_row
-    |> position_last_row
+    |> position_first_row()
+    |> position_last_row()
   end
 
   defp parse_rows([%{"trip_id" => trip_id} | _] = rows, trip_fn) do

apps/parse/lib/parse/vehicle_positions.ex

@@ -10,7 +10,7 @@ defmodule Parse.VehiclePositions do
     # gzip encoded
     blob
     |> :zlib.gunzip()
-    |> parse
+    |> parse()
   end
 
   def parse("{" <> _ = blob) do

apps/parse/lib/simple_csv.ex

@@ -10,7 +10,7 @@ defmodule SimpleCSV do
   """
   def decode(lines) do
     lines
-    |> stream
+    |> stream()
     |> Enum.to_list()
   end
 

apps/parse/test/parse/stop_times_test.exs

@@ -15,7 +15,7 @@ defmodule Parse.StopTimesTest do
   end
 
   test "parse: parses a CSV blob into a list of stops, tagging the first stop", %{blob: blob} do
-    assert blob |> parse |> Enum.sort() == [
+    assert blob |> parse() |> Enum.sort() == [
              %Schedule{
                trip_id: "29063613",
                stop_id: "2300",
@@ -61,7 +61,7 @@ defmodule Parse.StopTimesTest do
     "29063613","14:36:00","14:36:01","2300","6","","1","1","1"\r
     """
 
-    assert blob |> parse |> Enum.to_list() == [
+    assert blob |> parse() |> Enum.to_list() == [
              %Schedule{
                trip_id: "29063613",
                stop_id: "2300",
@@ -79,7 +79,7 @@ defmodule Parse.StopTimesTest do
 
   test "if given a fn which returns a trip, only returns schedules which match and includes the route_id",
        %{blob: blob} do
-    all_schedules = blob |> parse |> Enum.sort()
+    all_schedules = blob |> parse() |> Enum.sort()
 
     assert blob
            |> parse(fn trip_id ->

apps/state/lib/state/alert/filter.ex

@@ -9,7 +9,7 @@ defmodule State.Alert.Filter do
   @spec filter_by(Alert.filter_opts()) :: [Model.Alert.t()]
   def filter_by(filter_opts) do
     filter_opts
-    |> filter_to_list_of_ids
+    |> filter_to_list_of_ids()
     |> filter_by_ids(filter_opts)
     |> filter_by_informed_entity_activity(filter_opts)
     |> filter_by_active_period(filter_opts)
@@ -32,7 +32,7 @@ defmodule State.Alert.Filter do
   defp build_matchers(filter_opts) do
     filter_opts
     |> Enum.reduce([%{}], &do_build_matcher/2)
-    |> reject_empty_matchers
+    |> reject_empty_matchers()
     |> Enum.uniq()
   end
 

apps/state/lib/state/alert/informed_entity.ex

@@ -62,7 +62,7 @@ defmodule State.Alert.InformedEntity do
         facility: facility
       }
     end
-    |> reject_empty_parts
+    |> reject_empty_parts()
   end
 
   defp part_values(map, key) do

apps/state/lib/state/prediction.ex

@@ -98,7 +98,7 @@ defmodule State.Prediction do
       case Map.get(prediction, time_key) do
         %DateTime{} = dt ->
           dt
-          |> service_date
+          |> service_date()
           |> Kernel.==(date)
 
         nil ->