Skip to content

Rename utils.isLongTerm() -> is_long_term() #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbrukman merged 1 commit into from
Jan 27, 2026
Merged

Rename utils.isLongTerm() -> is_long_term() #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ def txf_date(date: datetime) -> str:
return date.strftime('%m/%d/%Y')


def isLongTerm(buy_date: datetime, sell_date: datetime) -> bool:
def is_long_term(buy_date: datetime, sell_date: datetime) -> bool:
# To handle leap years, cannot use a standard number of days, i.e.:
# sell_date - buy_date > timedelta(days=365)
# - doesn't work for leap years
Expand Down
6 changes: 3 additions & 3 deletions utils_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,18 @@ class UtilsTest(unittest.TestCase):
def testIsLongTermNonLeapYear(self):
buy = datetime(2010, 1, 4)
sell = datetime(2011, 1, 5)
self.assertTrue(utils.isLongTerm(buy, sell))
self.assertTrue(utils.is_long_term(buy, sell))

def testIsLongTermLeapYear(self):
buy = datetime(2008, 1, 4)
sell = datetime(2009, 1, 4)
self.assertFalse(utils.isLongTerm(buy, sell))
self.assertFalse(utils.is_long_term(buy, sell))

def testIsLongTermCorrectOrder(self):
buy = datetime(2005, 1, 1)
sell = datetime(2000, 1, 4)
# TODO: verify error message.
self.assertRaises(utils.ValueError, utils.isLongTerm, buy, sell)
self.assertRaises(utils.ValueError, utils.is_long_term, buy, sell)


if __name__ == '__main__':
Expand Down
2 changes: 1 addition & 1 deletion vanguard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def parseFileToTxnList(cls, filename: str, tax_year: Optional[int]) -> list[util
curr_txn.sellDateStr = utils.txf_date(sellDate)
curr_txn.saleProceeds = cls.netAmount(sell)

if utils.isLongTerm(buyDate, sellDate):
if utils.is_long_term(buyDate, sellDate):
curr_txn.entryCode = 323 # "LT gain/loss - security"
else:
curr_txn.entryCode = 321 # "ST gain/loss - security"
Expand Down
Loading