Handle KeyError in plain output#309
Open
atomicules wants to merge 1 commit into
Open
Conversation
Author
|
|
For whatever reason I get this error:
```
File "/home/simon/.local/lib/python3.11/site-packages/pdh/main.py", line 292, in inc_list
print_items(filtered, output, plain_print_f=plain_print_f)
File "/home/simon/.local/lib/python3.11/site-packages/pdh/output.py", line 96, in print_items
getattr(Output(), output)(
File "/home/simon/.local/lib/python3.11/site-packages/pdh/output.py", line 35, in plain
plain_print_f(i)
File "/home/simon/.local/lib/python3.11/site-packages/pdh/main.py", line 275, in plain_print_f
s += f"{i[f]}\t"
~^^^
KeyError: 'service.summary'
```
when trying to use plain output:
```
pdh inc ls -o plain
```
I don't know if that's specific to my PagerDuty setup or
`service.summary` is just wrong, but as an initial quick fix we can just
skip fields that we don't have.
Note: Committed with `--no-verify` as I have issues with ruff-pre-commit
(doesn't work on NetBSD), but I did run `ruff` on the changes.
atomicules
force-pushed
the
key-error-in-plain
branch
from
October 24, 2025 10:42
9717863 to
cc79244
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For whatever reason I get this error:
when trying to use plain output:
I don't know if that's specific to my PagerDuty setup or
service.summaryis just wrong, but as an initial quick fix we can just skip fields that we don't have.Note: Committed with
--no-verifyas I have issues with ruff-pre-commit (doesn't work on NetBSD), but I did runruffon the changes.