Skip to content

Remove duplicate \makeatletter - #2

Open
Ayarjay wants to merge 1 commit into
mbg:mainfrom
Ayarjay:patch-1
Open

Remove duplicate \makeatletter#2
Ayarjay wants to merge 1 commit into
mbg:mainfrom
Ayarjay:patch-1

Conversation

@Ayarjay

@Ayarjay Ayarjay commented Jun 20, 2021

Copy link
Copy Markdown

Removal of \makeatletter on line 46, query if intended to use \makeatother although note this will cause errors to later @ uses in the script.

Removal of `\makeatletter` on line 46, query if intended to use `\makeatother` although note this will cause errors to later \@<command> uses in the script.

@mbg mbg left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR and sorry for the delay in reviewing it!

Comment thread common/common.tex
\newcommand{\supervisor}[1]{\renewcommand{\@supervisor}{#1}}
\newcommand{\@yearofstudy}[0]{}
\newcommand{\yearofstudy}[1]{\renewcommand{\@yearofstudy}{#1}}
\makeatletter

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this probably should be an \makeatother I think

@mbg
mbg changed the base branch from master to main December 4, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants