fix sys gnuplot test#205
Merged
Merged
Conversation
Owner
|
@t-bltg Did you see https://discourse.julialang.org/t/deprecating-the-latest-and-vx-y-tags-of-the-julia-actions-setup-julia-github-action/136936 ? Am I misunderstanding that the |
Collaborator
Author
|
No, I haven't, thanks for pointing that out. Using PRs with a description (and the discourse url in it), linking to the commit would have helped understanding why |
Owner
|
I did link the conversation in the commit message. I'm used to just committing locally and pushing, but you make a good point that using PRs would be clearer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mbaz I do'nt understand the purpose of de67a8f.
When using
@latestsuffix, this ensure that we use the latestsetup-juliaactions, hence we don't have to manually change numbers e.g.@v3to@v4.Fix for de67a8f, making the preferences test against the system gnuplot conditional.