Preparatory refactors to supporting octopus merges - #131
Merged
Merged
Conversation
As it turns out, octopus merge nodes are a bit less rare than I originally thought and I have encountered several repos now that contains them, which I'd like to support with vcs. As a prerequisite, we are going to constrain the signature and what is exposed of the nodes, and in particular make the node kind an abstract type. Graph algorithm are still possible to write by matching on the shape of the node parents list, or making them generic in term of that same list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces refactor only as prerequisite to later on implement support for octopus merge nodes. At the tip of the PR the support is still not implemented, this is a pre-refactoring branch only. The implementation of the actual support is left out of scope for future work.
Breaking changes in the API:
Motivation
As it turns out, octopus merge nodes are a bit less rare than I originally thought and I have encountered several repos now that contains them, which I'd like to support with volgo-vcs. Sorry, my bad.
As a prerequisite, we are going to constrain the signature and what is exposed of the nodes, and in particular make the node kind an abstract type.
Graph algorithms are still possible to write in vcs user land by matching on the shape of the node parents list, or making them generic in term of that same list.