Skip to content

Refresh ride camera scope when vehicle attachment changes#4

Open
mayor-modder wants to merge 3 commits into
codex/follow-subject-through-vehiclesfrom
codex/vehicle-attachment-scope
Open

Refresh ride camera scope when vehicle attachment changes#4
mayor-modder wants to merge 3 commits into
codex/follow-subject-through-vehiclesfrom
codex/vehicle-attachment-scope

Conversation

@mayor-modder

@mayor-modder mayor-modder commented Jun 14, 2026

Copy link
Copy Markdown
Owner

This follows up by refreshing the camera's ride context whenever its temporary vehicle attachment changes. That fixes the rail-level ride camera and avoids asking localization for unresolved internal rail-track labels, which could trigger repeated errors.

Summary

  • Refresh vehicle/citizen scope when the resolved camera attachment target changes.
  • Recalculate ride offsets after a followed citizen attaches to a vehicle, so vehicle rides use the vehicle camera offset instead of the pedestrian offset.
  • Avoid rail-track label lookups in the transit strip map and ignore unresolved asset labels.

Stack

Stacked on: Cgameworld#9 (codex/follow-subject-through-vehicles).

Validation

  • dotnet test Tests/FollowTargetStateTests.csproj --no-restore (5 passed)
  • dotnet build FirstPersonCameraContinued.csproj /p:ModPublisherCommand=Update /m:1 /nodeReuse:false /p:UseSharedCompilation=false (0 errors; existing nullable warnings remain)
  • Local gameplay retesting followed a citizen through subway boarding and disembarking, and the subway ride used the vehicle-height camera instead of rail-level positioning.

Notes

This PR is intentionally opened in the fork because the stack base branch is not available in the upstream repository. After the base PR lands upstream, this branch can be retargeted or rebased for an upstream PR with the same focused diff.

@mayor-modder mayor-modder added agent-work Tracked by an agent-assisted workflow priority-high High priority issue area-camera Camera positioning, transforms, and view behavior labels Jun 14, 2026
@mayor-modder
mayor-modder marked this pull request as ready for review June 15, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-work Tracked by an agent-assisted workflow area-camera Camera positioning, transforms, and view behavior priority-high High priority issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant