chore(deps)(deps): bump go.uber.org/zap from 1.27.0 to 1.27.1 in /src/amqp-go#11
Open
dependabot[bot] wants to merge 1 commit into
Open
Conversation
Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.27.0 to 1.27.1. - [Release notes](https://github.com/uber-go/zap/releases) - [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md) - [Commits](uber-go/zap@v1.27.0...v1.27.1) --- updated-dependencies: - dependency-name: go.uber.org/zap dependency-version: 1.27.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
x0a1b
added a commit
that referenced
this pull request
Jul 8, 2026
…LX republish path (Bug#3)
Wave 2 final RabbitMQ-fidelity fix. The W7 conformance suite (run against real
RabbitMQ 4.3.2) confirmed a genuine divergence: dead-lettering a message into a
DLX target queue that is ALREADY at its own x-max-length caused StrangeQ to
OVERSHOOT the cap (keep both, depth 2), whereas RabbitMQ applies the target's
own x-overflow policy and stays at the cap. republishToTargets gated only on the
physical ring backpressure high-water mark (AtHighWaterMark), never on the target
queue's max-length / x-overflow (which were enforced only on the normal
PublishMessage path).
FIX A — republishToTargets now enforces the TARGET queue's overflow policy,
reusing the W5 max_length.go helpers (maxLenRejectsPublish, dropHeadTrim,
addReadyBytesOnEnqueue) and preserving the frozen non-blocking guarantee (never
WaitForCapacity):
- x-overflow=reject-publish AND at-or-over its limit: the dead-letter is
dropped for that target (a system dead-letter cannot be nacked back to a
publisher — the RabbitMQ-equivalent) and surfaced via a new
recordDeadLetterOverflow (WARN + the shared optional metrics hook). The
at-or-over check + enqueue run under the target's maxLenMu, mirroring
PublishMessage, so concurrent republishes cannot both admit past the cap.
- otherwise store + Publish + byte-account, then drop-head-with-limit targets
are trimmed (dropHeadTrim) so they stay AT their cap. dropHeadTrim runs
AFTER enqueue with NO lock held: it recursively dead-letters the evicted
head (reason=maxlen) through the same seam, and cycle detection keeps the
recursion finite — holding a lock across it could deadlock.
- AtHighWaterMark stays as the physical-ring backstop (never block); for a
policy-limited target the ring HWM sits far above x-max-length, so the
x-max-length semantics are what give RabbitMQ parity.
FIX B — basic.get-ok message-count now reports the READY-only remaining count
(GetQueueReadyCount == WaitingCount, minus the message being returned), symmetric
with the W7 queue.declare-ok fix and matching RabbitMQ's "messages remaining"
semantics. The storage ring count included delivered-but-unacked messages and
over-reported when unacked deliveries were outstanding.
Conformance: TestConformance_DeadLetterIntoFullTarget flipped from a documented
divergence (rabbit=[new], strangeq=[old,new]) to PARITY (both=[new]); added
TestConformance_DeadLetterIntoRejectPublishTarget (both=[keep]). Both re-verified
against real RabbitMQ 4.3.2. W7 finding #11 CONFIRMED-REAL -> FIXED.
Tests: new broker/dead_letter_target_overflow_test.go (drop-head count + bytes,
reject-publish drop + metrics observability, drop-head chaining to the target's
own DLX proving deadlock-free recursion) and broker/get_ready_count_test.go
(ready-remaining baseline + unacked-outstanding case). gofmt + go vet clean;
go test ./... green; broker -race green; make conformance green.
Note (out of scope, flagged): a no-ack basic.get settles neither the storage
ring nor the ready counter — a pre-existing message/counter leak on that path,
separate from this fix.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps go.uber.org/zap from 1.27.0 to 1.27.1.
Release notes
Sourced from go.uber.org/zap's releases.
Changelog
Sourced from go.uber.org/zap's changelog.
Commits
7b755a3release 1.27.1 (#1521)d6b395bUpdate lazy logger not to materialize unless it's being written to (#1519)4b9cea0ci: Test with Go 1.24, Go 1.25 (#1508)7c80d7bFix race condition in WithLazy implementation (#1426) (#1511)07077a6Prevent zap.Object from panicing on nils (#1501)a6afd05Fix lint check name (#1502)6d48253chore: fix typo (#1482)32f2ec1Fix the field test for bool type (#1480)fe16eb5Upgrade grpc in zapgrc test package & bump go version (#1478)5f00c34test(AtomicLevel): demonstrate Handler is not vulnerable to XSS (#1477)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)