fix(cli): build @parallax/slack during prepack#35
Merged
Conversation
prepare-package.mjs copies packages/slack/dist into the bundled package but never built it — the build step was missing from main(). On a clean CI checkout packages/slack/dist does not exist, so prepack failed with ENOENT during the npm publish. Add the slack build alongside the other bundled packages. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The release retry failed again — this time in
prepack:Follow-up to #34. That PR added
@parallax/slackto the bundled packages (soprepare-package.mjscopiespackages/slack/dist), but themain()build step that compiles each bundled package before copying was never updated to build slack. On a fresh CI checkoutpackages/slack/distdoesn't exist yet, so the copy fails. It passed locally only because slack had been built earlier.Fix
Add
runPnpm(['--filter', '@parallax/slack', 'build'])alongside the other bundled-package builds inmain().Verification
Reproduced the CI condition locally by deleting all
packages/*/distdirs, then ranpnpm --filter parallax-cli pack:check:Release
After merge, re-run the Release parallax-cli workflow to publish
0.1.0.🤖 Generated with Claude Code