fix(tests): extend the spawn pin to benches; correct the pin's cost note - #3792
Merged
Conversation
Benches spawned env!("CARGO_BIN_EXE_wt") directly — the same uplifted
path the suite stopped spawning — so a sibling build could fail a bench
run's spawns; route them through wt_bin() and widen
test_wt_spawns_are_pinned's scan to benches/. The pin docstring claimed
the hardlink shares the deps artifact's inode: true where cargo uplifts
by hardlink (Linux), but on macOS the uplift is a copy-on-write clone —
the pin keeps the clone, whose blocks stay shared with deps (measured:
cloning the 70 MB binary consumes 8 KB), so the cost conclusion stands
with the mechanism stated per platform.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
worktrunk-bot
approved these changes
Aug 9, 2026
worktrunk-bot
left a comment
worktrunk-bot
left a comment
Collaborator
There was a problem hiding this comment.
Removing the use std::path::Path; line left its #[cfg(unix)] behind, so use wt_perf::{…} now carries the attribute twice. It compiles and lint is green (clippy's duplicated_attributes doesn't fire on repeated cfg), but it reads as an editing slip — suggestion inline.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3784, prompted by a history audit of the spawn-flake family. Benches still spawned
env!("CARGO_BIN_EXE_wt")— the uplifted path the suite stopped spawning — so a concurrent build could fail a bench run's spawns; all 11 sites now route throughwt_bin()andtest_wt_spawns_are_pinnedscansbenches/too, making the rule exceptionless. The pin's docstring also claimed the hardlink shares thedeps/artifact's inode: true where cargo uplifts by hardlink (Linux), but macOS uplifts by copy-on-write clone — the pin keeps the clone, whose blocks stay shared withdeps/(measured: cloning the 70 MB binary consumes 8 KB), so the no-cost conclusion stands with the mechanism now stated per platform, plus why nothing sweeps the directory.