fix(running-in-ci): recheck immediately before the post, and count sweeps as siblings - #893
Merged
Merged
Conversation
tend-agent
commented
Aug 7, 2026
tend-agent
left a comment
Collaborator
Author
There was a problem hiding this comment.
One suggestion inline. The ordering clause reads well and the cross-reference to the gh pr create rule is accurate — that rule does say "as the last step before gh pr create", and it does sit above this section. tend-nightly, tend-review-runs, tend-notifications and tend-triage's issues: opened trigger all check out against generator/src/tend/workflows.py and the generated workflow files.
review-reviewers is tend's own hand-maintained workflow; the generator never stamps it, so no adopter has one. Naming it flat in a bundled skill reads as universal. Follow review-runs/SKILL.md and point at the repo's running-tend skill for the non-tend-* list.
This was referenced Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bot comments answering the same freshly-filed issue, 18 seconds apart, with independently-derived but substantively identical content. Every dedup guard in
running-in-ciwas followed; the guard for comments just doesn't say when to run the re-fetch, and the sibling guard forgh pr create100 lines up does.The race, from the two session logs
Issue opened 08:20:35Z by an outside consumer's bot.
tend-triagefired onissues: openedand queued. The scheduledtend-review-runsrun, already in session since 08:10:33Z, found the same issue in its survey at 08:22:24Z and started composing an answer to it.tend-triagetend-review-runstend-triagetend-review-runsgh issue view … --json state,comments→ 0 bot comments. Correct at that instant.tend-triagegh issue comment→ first commenttend-review-runstend-review-runsThe recheck was 22 seconds stale by the time the post went out, and the work that consumed those 22 seconds was the pre-post hygiene the same skill file asks for — compose the body, grep it for
PLACEHOLDER/<SHA>/<TODO>, check everygithub.com/owner. Moving the recheck after that hygiene would have caught it: the triage comment existed from 08:29:08, a full 18 seconds before the post.Change
Two sentences in Recheck Before Posting, no new section:
gh pr create" — applied to the comment path, which currently says only "before posting".tend-mention,tend-triage,tend-review. The run that duplicated here was a scheduled sweep, and a reader of the current list would reasonably conclude sweeps aren't in scope. Widen it to "every workflow posts as the same bot account", and call out the sharpest case:tend-triageownsissues: opened, so a sweep already in session that finds the same fresh issue is racing a run that already owns it.Not proposed here: a positive in-flight check (query
actions/runsfor a concurrenttend-*run on the same subject before posting) — thenotificationsskill has one and it would also have caught this. That's a new guard on every posting path rather than an ordering clause on an existing one, so it needs more than one occurrence behind it. Recorded in the evidence log instead.Gate assessment
gh pr create. Lowest bar on the Gate 2 table, and the reason I was willing to act on a single occurrence — the cost of being wrong here is one clause.Adjacent but distinct, checked for overlap: #865 / #870 cover a review landing while a session polls its own PR's CI; #867 covers
tend-ci-fixnot seeing a sibling's tracker. Neither touches this section or this race.Evidence log: https://gist.github.com/e08f6e62d6478163cb425a75648eb7e4