Skip to content

fix(running-in-ci): batch pushes so the author doesn't cancel its own reviewer #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-sixty merged 2 commits into from
Aug 7, 2026
Merged

fix(running-in-ci): batch pushes so the author doesn't cancel its own reviewer #868

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe988ac
fix(running-in-ci): batch pushes so the author doesn't cancel its own…
tend-agent Aug 6, 2026
2c26395
fix(running-in-ci): apply review wording — any push, any new-informat…
tend-agent Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions plugins/tend-ci-runner/skills/running-in-ci/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,15 @@ Always use `git push` without specifying a remote — `gh pr checkout` configure

If pushing fails (fork PR with edits disabled), fall back to posting code snippets in a comment. Don't reference commit SHAs from temporary branches — post code inline.

### Batch the push — every push restarts the reviewer

`tend-review` triggers on `synchronize` under a per-PR concurrency group at `cancel-in-progress: true`, so each push to a PR starts a fresh review run and cancels the one already running. Push twice in quick succession and the first reviewer is killed at startup having produced nothing; push after several minutes and it dies with whatever review it had assembled unsubmitted.

- **Commit everything before `gh pr create`.** Changelog entries, test pins, and formatting fixups belong in the initial push, not a follow-up thirty seconds later.
- **Make the commits, then push once** — not a push after each commit. Amends and rebases count: a force-push fires `synchronize` too.

A follow-up push that acts on information the session didn't have at push time — review feedback, a red check — *should* invalidate the running review; that one is correct. What's wasteful is splitting work you already have into several pushes.

### Re-check PR state before pushing a follow-up commit

Any wait that lets time pass — a CI poll, coverage fetch, sleep, background task — also gives a maintainer time to merge or close the PR. After waiting:
Expand Down
Loading