docs: correct run.rs widen condition in CLAUDE.md (unreachable, not diverged) - #47
Open
cargo-affected-bot wants to merge 3 commits into
Open
docs: correct run.rs widen condition in CLAUDE.md (unreachable, not diverged)#47cargo-affected-bot wants to merge 3 commits into
cargo-affected-bot wants to merge 3 commits into
Conversation
…iverged) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…den-divergence # Conflicts: # CLAUDE.md
…den-divergence # Conflicts: # CLAUDE.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
run.rsarchitecture bullet inCLAUDE.mdsaid run "Widens to all tests only when every sha is diverged." That conflicts withrun.rs's own vocabulary:CacheStatus::HitWithDivergence/any_divergence()describe the reachable-but-not-equal case, and that path does not widen — it proceeds with the partial selection. Widening to the full suite happens on theMissNoReachableShapath, which fires only whenreach.reachable.is_empty()— i.e. every storedcollect_shais missing (rebased/pruned/gc'd/beyond a shallow-clone boundary), per theReachability::missingdoc insrc/selection.rs.So a reader following run.rs's terms would expect a diverged sha to trigger a full rerun, when it actually keeps the narrow selection. This updates the bullet to say widening happens only when no
collect_shais reachable, and that a reachable-but-diverged sha keeps the partialhit-with-divergenceselection.Docs-only change — no regression test (nothing executable changed). Grounded in
src/run.rs(thereach.reachable.is_empty()guard andclassify_hit_status/any_divergence) andsrc/selection.rs(theReachabilityfield docs).Adjacent to the
selection.rsbullet edited by #36 but a distinct line and concern.🤖 Generated with Claude Code