tests: refresh duplicate-basename comments for NEXTEST_BINARY_ID shim - #31
tests: refresh duplicate-basename comments for NEXTEST_BINARY_ID shim#31cargo-affected-bot wants to merge 3 commits into
Conversation
The shim now sources binary_id from NEXTEST_BINARY_ID (PR #14); these test docstrings still describe the older triple-based lookup, the pre-run binary_map, and the byte-marker fallback. Update comments to match the current mechanism. No code or assertion changes.
cargo-affected-bot
left a comment
There was a problem hiding this comment.
In-diff comments are accurate against src/shim.rs. Two adjacent lines in the same files were left referring to the old shim and fit the same refresh:
tests/functional/duplicate_target_names.rs#L60-L61— thecargo_affected_strippedhelper docstring still attributes theRUSTFLAGS='-C debuginfo=0'to defeating "the old marker fallback". The sibling helper inlib_bin_collision.rs:88-90already carries the up-to-date rationale (mirror the stripped-binary CI environment that originally tripped the bug).tests/functional/lib_bin_collision.rs#L120-L121— the assertion message reads "marker probe must disambiguate lib+bin", but the marker probe is gone; the!stderr.contains("basename fallback ambiguous")check itself is still a valid regression guard.
Both are out-of-diff so I haven't posted inline suggestions; happy to push a follow-up commit if you'd like them folded in.
The shim resolves binary_id from NEXTEST_BINARY_ID (shim.rs: "no marker probe needed"); the panic message still described the defunct marker probe. The sibling "probe path" comment was already refreshed in this PR. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Added one follow-up commit: the assert panic message at line 121 still said "marker probe must disambiguate lib+bin", referencing the same defunct mechanism this PR removes elsewhere. Updated it to "NEXTEST_BINARY_ID must disambiguate lib+bin" to match |
The cargo_affected_stripped helper docstring still attributed the RUSTFLAGS='-C debuginfo=0' to defeating the old marker fallback. That mechanism is gone; debuginfo=0 now just mirrors the stripped-binary CI environment that originally tripped the duplicate-basename bug, matching the sibling helper in lib_bin_collision.rs and this file's own header. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Pushed one more follow-up: the |
The
duplicate_target_names.rsandlib_bin_collision.rstest files document the binary-resolution mechanism in their docstrings and inline comments. Those mechanisms changed in PR #14 (shim: source binary_id from NEXTEST_BINARY_ID, drop the binary map), but the comments still describe the prior approaches:(package, target, kind)triple-based lookup that PR Disambiguate lib+bin same-basename collisions in shim marker probe #14 replaced.<package>::<target>id directly.The test scenarios themselves are still valid regression guards (duplicate basenames + stripped debuginfo + partial rebuild are real-world shapes), but the explanatory comments mislead future readers about how the current shim resolves binaries.
This PR refreshes only the comments — no code or assertion changes, no behavioural shift.