Added readOnly option#167
Open
jjwilliams wants to merge 2 commits into
Open
Conversation
…ove the "tagCloseIcon" from being rendered
Author
|
Also I don't know if this is needed: |
Collaborator
|
Why show the input box at all if in read only mode? |
|
Good point, I could just hide it altogether. I'll look into that tomorrow. |
Author
|
Hid the textbox if readOnly |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make the input box readonly, and remove the tagCloseIcon from being rendered.
Fairly simple - I might be missing something. Wasn't sure if I should .attr('readonly', true) the field or disable the field. Readonly will still get posted, although I'm not sure why a tagManager's textbox would need to be posted back.