Skip to content

test(VideoManager): address Windows sink review follow-up - #14752

Open
alireza787b wants to merge 1 commit into
mavlink:masterfrom
alireza787b:agent/windows-system-memory-review-followup
Open

test(VideoManager): address Windows sink review follow-up#14752
alireza787b wants to merge 1 commit into
mavlink:masterfrom
alireza787b:agent/windows-system-memory-review-followup

Conversation

@alireza787b

@alireza787b alireza787b commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Description

This is the post-merge review cleanup requested on #14728.

It does not change runtime behavior. It:

  • clarifies why the D3D11 sink advertises only native GPU formats;
  • removes asynchronous waits from synchronous caps assertions;
  • removes an unused videotestsrc property; and
  • narrows the Windows skip condition to D3D11-specific initialization failures.

The original CPU-frame fallback was reproduced and verified by the maintainer before #14728 was merged. This follow-up does not claim separate hardware-decoder coverage for 4:2:2 or 4:4:4 streams.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change or feature
  • Documentation update
  • Refactoring (no functional changes)
  • CI/Build changes
  • Other

Testing

  • Tested locally: reviewed the focused diff and ran git diff --check
  • Added/updated unit tests

Exact PR head: 37fc2884e83d733d15efcf839b40175a9cda0cd6.

  • Exact-head QGC CI passed Linux x64/arm64 release builds, unit and integration tests, ASan/UBSan, coverage thresholds, Windows, macOS, iOS, Android, Docker, custom-plugin, and CodeQL checks. Linux evidence: run 30596390058
  • Codecov reports every modified coverable line covered
  • Tested with simulator (not applicable)
  • Tested with hardware (no new runtime behavior)

Platforms Tested

Flight Stacks Tested

Not applicable; this only refines GStreamer sink tests and comments.

Screenshots

Not applicable; there is no UI change.

Checklist

  • I have read the Contribution Guidelines
  • I have read the Code of Conduct
  • My code follows the project coding standards
  • I have updated tests to capture the reviewed behavior
  • New and existing unit and integration tests pass at the exact head in QGC CI

Related Issues

Follow-up to #14728.


By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.65%. Comparing base (f29efd3) to head (37fc288).
⚠️ Report is 236 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14752      +/-   ##
==========================================
+ Coverage   25.47%   32.65%   +7.18%     
==========================================
  Files         769      784      +15     
  Lines       65912    67564    +1652     
  Branches    30495    31292     +797     
==========================================
+ Hits        16788    22061    +5273     
+ Misses      37285    30629    -6656     
- Partials    11839    14874    +3035     
Flag Coverage Δ
unittests 32.65% <ø> (+7.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 477 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed09a05...37fc288. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 0 passed, 0 failed, 0 skipped.

Test Results

linux-coverage-integration: 37 passed, 0 skipped
linux-coverage-unit: 117 passed, 0 skipped
linux-sanitizers-integration: 20 passed, 0 skipped
linux-sanitizers-unit: 117 passed, 0 skipped
Total: 291 passed, 0 skipped

Code Coverage

Coverage: 69.4%

No baseline available for comparison

Artifact Sizes

Artifact Size
QGroundControl 221.80 MB
QGroundControl-aarch64 179.35 MB
QGroundControl-installer-AMD64 137.85 MB
QGroundControl-installer-AMD64-ARM64 80.35 MB
QGroundControl-installer-ARM64 109.10 MB
QGroundControl-linux 87.04 MB
QGroundControl-mac 87.04 MB
QGroundControl-x86_64 191.58 MB
No baseline available for comparison

Updated: 2026-07-31 02:06:37 UTC • Commit: 37fc288 • Triggered by: Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant