cmake: update MAVLink to latest upstream (c409cf6) - #14462
Conversation
There was a problem hiding this comment.
Pull request overview
Updates QGroundControl’s pinned MAVLink upstream commit in CMake so CPM fetches and regenerates headers from the latest mavlink/mavlink master snapshot referenced in the PR description.
Changes:
- Bump
QGC_MAVLINK_GIT_TAGfromb1fb5a1…toc409cf6…incmake/CustomOptions.cmake.
|
See the Build Results workflow run for details. |
Bumps the MAVLink commit pin from b1fb5a1 to c409cf6 (2026-06-02). Notable change: BATTERY_STATUS_V2 replaces the uint8 percent_remaining field with a float state_of_charge field (0-100/NaN). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
a7734df to
0a6e821
Compare
|
@peterbarker @Davidsastresas FYI this updates MAVLink definitions to latest, which I needed to do for the I haven't done the work of updating the GCS to understand the secondary GCS under control and so on. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14462 +/- ##
==========================================
+ Coverage 25.47% 29.14% +3.67%
==========================================
Files 769 771 +2
Lines 65912 66422 +510
Branches 30495 30638 +143
==========================================
+ Hits 16788 19360 +2572
+ Misses 37285 33899 -3386
- Partials 11839 13163 +1324
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 295 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
@HTRamsey This should be good to go now. |
|
Thanks for the notification @hamishwillee. I am precisely right now working on the multi-GCS updates for QGC, and I already did this mavlink update on my local environment, so everything is on track already. I will make a pull request in the next few days about it for QGC. |
|
Great. I don't mind how the update happens, but this blocks me for battery fixes. |
|
I am good with this PR, it is the same mavlink tag I was using for the current work in the multi GCS front. I used to have authority to merge QGC PR but it seems I no longer have! I think we need Holden or Don to approve it. |
|
@Davidsastresas You should still have authority but I think when a review is requested it has to be approved first, and I think I get auto-requested for cmake changes based on codeowners (I forgot that means it requires my approval) |
|
whoops accidentally did a merge scrolling on my phone |
|
@HTRamsey that makes sense, thanks for the clarification! |
|
Thanks. It turns out that we're still refining the battery messages, so probably we'll have to go through this again soon. |
Summary
QGC_MAVLINK_GIT_TAGincmake/CustomOptions.cmakefromb1fb5a1toc409cf6(2026-06-02, latestmavlink/mavlinkmaster).BATTERY_STATUS_V2replaces theuint8_t percent_remainingfield (0–100 /UINT8_MAX= invalid) with afloat state_of_chargefield (0–100 /NaN= invalid). Any in-tree code that consumesBATTERY_STATUS_V2will need to be updated accordingly.Yeah, this is just update so I can bump #14269 to latest version of MAVLink.
Test plan
just configureto confirm CPM fetches the new commit cleanly and headers regenerate without errors.🤖 Generated with Claude Code