Mavgencpp example - #733
Merged
Merged
Conversation
julianoes
reviewed
Jul 16, 2026
|
|
||
| ::: warning | ||
| Only include the header file for a single dialect. | ||
| If you need to support messages from a _number of dialects_ then create a new "parent" dialect XML file that includes them (and use its generated header as shown above). |
| "COLORMODE", | ||
| "compid", | ||
| "configurators", | ||
| "constexpr", |
Comment on lines
+162
to
+163
| Unlike the C library, the C++ 11 generator does **not** emit a `mavlink::mavlink_get_msg_entry()` lookup function. | ||
| `mavlink_parse_char()` needs this internally to find the length and CRC extra of an incoming message id, so you must provide it yourself before parsing will work. |
Contributor
There was a problem hiding this comment.
That's odd, isn't it. I need to look at that at some point.
Collaborator
Author
There was a problem hiding this comment.
Very. Thought the same. I wonder if there is a reason for this.
Collaborator
Author
|
@julianoes So is this "good enough"? (i.e. no approval could mean it isn't, or that you forgot, or that you still haven't finished) |
Contributor
|
I think this is good sorry. We can always improve it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the MAVLink libary with information about using the C++ 11 library, following addition of the example in mavlink/mavlink#2548
@julianoes I don't actually know much about the differences so I asked Claude to write it based on the example and comparison of the generated outputs. It looks very reasonable, but of course I don't know C++ very well.
Can you sanity check this "at your convenience". If it is too much to do, then we could just cut it back to the example - but it seems like a very useful thing to have this level of docs.