Fix MAVLink 2 overhead byte counts - #731
Merged
Merged
Conversation
The MAVLink 2 packet has 12 bytes of overhead (a zero-payload packet is 12 bytes), not 14; with signing it is 25 (12 + 13-byte signature), not 27. Also correct the signature row byte range in the serialization table: signature[13] spans (n+12) to (n+24), not (n+25). Fixes #184
hamishwillee
approved these changes
Jul 15, 2026
Collaborator
|
Thanks very much @julianoes - really good to get these old issues cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #184.
The FAQ and homepage stated that MAVLink 2 has "14 bytes of overhead (27 if signing is used)". Both numbers are wrong:
This updates
en/about/faq.mdanden/index.mdaccordingly.While in the serialization table, also corrected the signature row byte range: a
signature[13]field spans(n+12) to (n+24)(14 positions would be off-by-one), not(n+12) to (n+25).