FTP: Fix off-by-one in data byte index range - #730
Merged
Conversation
The FILE_TRANSFER_PROTOCOL payload is 251 bytes (indices 0-250), so the data[] field spans indices 12 to 250, not 12 to 251. Fixes #728
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the byte index range for the
data[]field in the MAVFTP Payload Format table.The
FILE_TRANSFER_PROTOCOLmessage'spayloadfield has a length of 251 bytes, so valid indices run from 0 to 250. Since the header occupies bytes 0–11, the data field spans indices 12 to 250 (239 bytes), not 12 to 251.Change
en/services/ftp.md:12 to (max) 251→12 to (max) 250Fixes #728