Repository navigation
Fix enabling fsspec disabling URL read mode and ActionJsonnet.parse failing with a Path - #1017
Conversation
…ailing with a Path
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1017 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 9845 9844 -1
=========================================
- Hits 9845 9844 -1 ☔ View full report in Codecov by Harness. |
|
[Medium impact] The changes affect two bounded library workflows. The fixes appear safe to merge, with a non-blocking cleanup improvement for the new regression test. Findings
SummaryFixes two parsing bugs:
Adds regression tests and improves cleanup of read modes between tests. One non-blocking test-isolation issue remains: the new combined-mode test skips cleanup if an assertion fails. Reviews (1) · Last reviewed commit: "Fix enabling fsspec disabling URL read m..." · Reviewed by Greptile |



What does this PR do?
Fixes two bugs:
set_parsing_settingsgiven only one ofconfig_read_mode_urls_enabledorconfig_read_mode_fsspec_enabledsilently disabled the other mode if it had been enabled earlier, e.g. enabling fsspec after URLs changed the read mode fromfurtofsr. Now a setting that isn't given is left as it is.ActionJsonnet.parsegiven aPathfailed withTypeError: 'Path' object is not callable, because it still calledPathlike a function, which is no longer supported.Fixing the first bug exposed tests that left URL or fsspec read mode enabled for the tests that ran after them. The
patch_parsing_settingstest helper now also restores the read mode, and the fsspec secrets fixture disables fsspec when it is done.Before submitting