Skip to content

[MM-63260] Fixed comments select text under each card - issue #63#102

Open
iosifpeterfi wants to merge 1 commit into
mattermost:mainfrom
iosifpeterfi:main
Open

[MM-63260] Fixed comments select text under each card - issue #63#102
iosifpeterfi wants to merge 1 commit into
mattermost:mainfrom
iosifpeterfi:main

Conversation

@iosifpeterfi

@iosifpeterfi iosifpeterfi commented May 21, 2025 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown

Summary

This allows users to select text under comments on the board

Ticket Link

Fixes #63
Fixes MM-63260

@iosifpeterfi
Fixed issue mattermost#63
d7d3de4 
Issue documented here:

mattermost#63
@iosifpeterfi iosifpeterfi changed the title Fixed comments select tracked under issue #63 [MM-63260] Fixed comments select tracked under issue #63 May 21, 2025
@iosifpeterfi iosifpeterfi changed the title [MM-63260] Fixed comments select tracked under issue #63 [MM-63260] Fixed comments select text under each card - issue #63 May 21, 2025
@iosifpeterfi iosifpeterfi mentioned this pull request May 21, 2025
Merged
@marianunez
marianunez requested a review from Rajat-Dabade July 11, 2025 13:38
@marianunez marianunez added the 2: Dev Review Requires review by a core committer label Jul 11, 2025
@marianunez marianunez added the 3: QA Review Requires review by a QA tester label Jul 11, 2025
Rajat-Dabade
Rajat-Dabade suggested changes Jul 15, 2025
View reviewed changes
Comment thread webapp/src/components/cardDetail/comment.scss

.comment-markdown > * {
white-space: pre-wrap;
user-select: auto;

@Rajat-Dabade Rajat-Dabade Jul 15, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not user-select: text if we are sure about allowing the user to select the text inside the element?
user-select: auto leaves the decision up to the browser’s default behaviour or what’s inherited from parent elements.

@iosifpeterfi iosifpeterfi Jul 28, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, is probably best to have it as 'text', since 'auto' can have different outcome.

@peetCreative

peetCreative commented Oct 29, 2025 •
edited
Loading

Copy link
Copy Markdown

@Rajat-Dabade How is the progress here?

@peetCreative peetCreative mentioned this pull request Nov 3, 2025
Open
@peetCreative

peetCreative commented Nov 5, 2025

Copy link
Copy Markdown

@iosifpeterfi may you merge and apply the suggestions form @Rajat-Dabade?

iosifpeterfi#1

@mattermost-build

mattermost-build commented Nov 16, 2025

Copy link
Copy Markdown
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

@peetCreative peetCreative mentioned this pull request May 8, 2026
Closed
@peetCreative

peetCreative commented Jun 5, 2026

Copy link
Copy Markdown

This was solved here, can be closed. @iosifpeterfi
6e90b8d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yasserfaraazkhan yasserfaraazkhan yasserfaraazkhan approved these changes
@harshilsharma63 harshilsharma63 harshilsharma63 approved these changes
+1 more reviewer
@Rajat-Dabade Rajat-Dabade Rajat-Dabade requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester Lifecycle/1:stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: No ability to copy comments

7 participants

@iosifpeterfi @peetCreative @mattermost-build @yasserfaraazkhan @harshilsharma63 @Rajat-Dabade @marianunez