fix: session attributes pod - #10080
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (5)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe PR updates the network client dependency to 1.11.1. It replaces the deprecated SessionAttributes pod references and updates three iOS imports to the new session attributes module. ChangesSession attributes integration
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The dependency-resolution fix presents no actionable merge-blocking risk at the current head; it is merge-ready after normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Coverage Comparison Report |
|
Cherry pick is scheduled. |
The merge in 528e0d8 resolved conflicts by taking the pre-merge side, which silently reverted two features already on main: - Session Attributes (MM-68986/MM-69203, #9830 + #10073 + #10080): all 40 files, incl. the @mattermost/react-native-network-client 1.11.1 -> 1.10.3 downgrade, the LocationWhenInUse pod/permission and the react-native-network-client-session-attributes pods. - Deep link handler fix (#9919): propsToParams param encoding in restore_server/routes/index/launch, the (home)/index param forwarding and the async redirectSystemPath + top-level handleUrl in +native-intent. All of these files are restored verbatim from main. The Detox/e2e changes this branch owns are untouched.
Summary
This PR fixes the issue where the mobile app is not building cause of a conflict with the session attributes pod resolution.
Ticket Link
N/A
Release Note