Skip to content

fix: session attributes pod - #10080

Merged
amyblais merged 1 commit into
mainfrom
fix-session-attributes-pod
Aug 20, 2026
Merged

fix: session attributes pod#10080
amyblais merged 1 commit into
mainfrom
fix-session-attributes-pod

Conversation

@enahum

@enahum enahum commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR fixes the issue where the mobile app is not building cause of a conflict with the session attributes pod resolution.

Ticket Link

N/A

Release Note

NONE

@enahum enahum added the 2: Dev Review Requires review by a core commiter label Aug 20, 2026
@mattermost-build mattermost-build added the E2E/Run Triggers E2E tests on both iOS and Android via Matterwick label Aug 20, 2026
@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d72b26d5-6602-4d0c-a0cb-d903a795b717

📥 Commits

Reviewing files that changed from the base of the PR and between 88a2337 and 038982c.

⛔ Files ignored due to path filters (2)
  • ios/Podfile.lock is excluded by !**/*.lock
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (5)
  • ios/GekidouWrapper.swift
  • ios/MattermostShare/ShareViewController.swift
  • ios/NotificationService/NotificationService.swift
  • ios/Podfile
  • package.json

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The PR updates the network client dependency to 1.11.1. It replaces the deprecated SessionAttributes pod references and updates three iOS imports to the new session attributes module.

Changes

Session attributes integration

Layer / File(s) Summary
Update package and CocoaPods wiring
package.json, ios/Podfile
The network client dependency changes from 1.11.0 to 1.11.1. The NotificationService and MattermostShare targets use the renamed session attributes pod.
Update iOS module imports
ios/GekidouWrapper.swift, ios/MattermostShare/ShareViewController.swift, ios/NotificationService/NotificationService.swift
The three iOS components import react_native_network_client_session_attributes instead of react_native_network_client.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 03898

The dependency-resolution fix presents no actionable merge-blocking risk at the current head; it is merge-ready after normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the fix for the session attributes pod issue.
Description check ✅ Passed The description explains that the pull request fixes a mobile app build issue caused by session attributes pod resolution.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-session-attributes-pod

Comment @coderabbitai help to get the list of available commands.

@enahum
enahum requested review from amyblais and devinbinnie August 20, 2026 10:05
@amyblais amyblais added this to the v2.44.0 milestone Aug 20, 2026
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Aug 20, 2026
@github-actions

Copy link
Copy Markdown

Coverage Comparison Report

Generated on August 20, 2026 at 10:11:53 UTC

+-----------------+------------+------------+-----------+
| Metric          | Main       | This PR    | Diff      |
+-----------------+------------+------------+-----------+
| Lines           |     88.40% |     88.40% |     0.00% |
| Statements      |     88.27% |     88.27% |     0.00% |
| Branches        |     77.34% |     77.34% |     0.00% |
| Functions       |     87.75% |     87.75% |     0.00% |
+-----------------+------------+------------+-----------+
| Total           |     85.44% |     85.44% |     0.00% |
+-----------------+------------+------------+-----------+

@amyblais amyblais added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Aug 20, 2026
@mattermost-build mattermost-build removed the E2E/Run Triggers E2E tests on both iOS and Android via Matterwick label Aug 20, 2026
@yasserfaraazkhan yasserfaraazkhan added E2E/Override Skip Running E2E tests E2E/Verified Mark known-flaky failing E2E checks as success and removed E2E/Override Skip Running E2E tests labels Aug 20, 2026
@amyblais
amyblais merged commit 58d0fca into main Aug 20, 2026
170 of 178 checks passed
@mattermost-build

Copy link
Copy Markdown
Contributor

Cherry pick is scheduled.

@amyblais
amyblais deleted the fix-session-attributes-pod branch August 20, 2026 12:00
@mattermost-build mattermost-build added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Aug 20, 2026
amyblais pushed a commit that referenced this pull request Aug 20, 2026
(cherry picked from commit 58d0fca)

Co-authored-by: Elias Nahum <nahumhbl@gmail.com>
yasserfaraazkhan added a commit that referenced this pull request Aug 20, 2026
The merge in 528e0d8 resolved conflicts by taking the pre-merge side,
which silently reverted two features already on main:

- Session Attributes (MM-68986/MM-69203, #9830 + #10073 + #10080): all 40
  files, incl. the @mattermost/react-native-network-client 1.11.1 -> 1.10.3
  downgrade, the LocationWhenInUse pod/permission and the
  react-native-network-client-session-attributes pods.
- Deep link handler fix (#9919): propsToParams param encoding in
  restore_server/routes/index/launch, the (home)/index param forwarding and
  the async redirectSystemPath + top-level handleUrl in +native-intent.

All of these files are restored verbatim from main. The Detox/e2e changes
this branch owns are untouched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: Reviews Complete All reviewers have approved the pull request CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone E2E/Verified Mark known-flaky failing E2E checks as success release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants