[MM-69735] Improve DM call user experience by M-ZubairAhmed · Pull Request #10017 · mattermost/mattermost-mobile

M-ZubairAhmed · 2026-08-06T17:04:48Z

Summary

Ticket Link

Checklist

Added or updated unit tests (required for all new features)
Has UI changes
Includes text changes and localization file updates
Have tested against the 5 core themes to ensure consistency between them.
Have run E2E tests by adding label E2E/Run (or E2E/Run-iOS / E2E/Run-Android for platform-specific runs).

Device Information

This PR was tested on:

Screenshots

Release Note

Improved DM call experience to phone like calls behavior.

M-ZubairAhmed · 2026-08-06T17:06:23Z

/update-branch

mattermost-build · 2026-08-06T17:06:27Z

Error trying to update the PR.
Please do it manually.

M-ZubairAhmed · 2026-08-07T18:38:41Z

/update-branch

mattermost-build · 2026-08-07T18:38:44Z

Error trying to update the PR.
Please do it manually.

…9987)

github-actions · 2026-08-07T18:47:25Z

Coverage Comparison Report

Generated on August 24, 2026 at 12:02:14 UTC

+-----------------+------------+------------+-----------+
| Metric          | Main       | This PR    | Diff      |
+-----------------+------------+------------+-----------+
| Lines           |     88.39% |     88.42% |     0.03% |
| Statements      |     88.25% |     88.28% |     0.03% |
| Branches        |     77.33% |     77.46% |     0.13% |
| Functions       |     87.73% |     87.79% |     0.06% |
+-----------------+------------+------------+-----------+
| Total           |     85.42% |     85.48% |     0.06% |
+-----------------+------------+------------+-----------+

M-ZubairAhmed · 2026-08-09T19:39:33Z

/update-branch

mattermost-build · 2026-08-09T19:39:36Z

Error trying to update the PR.
Please do it manually.

M-ZubairAhmed · 2026-08-17T01:52:53Z

/update-branch

mattermost-build · 2026-08-17T01:52:56Z

Error trying to update the PR.
Please do it manually.

…9987)

…tiation and hide "People" button in 1:1 DM Call (#10031)

enahum · 2026-08-18T17:41:43Z

And the callee doesn't get prompted to allow their mic in this state from the lock screen CallKit UI.

Callkit does not allow to request a permission in the lock screen, we should probably request the permission when the user uses the app and we detect that the server has calls installed proactively and not on first use

@matthewbirtch

matthewbirtch · 2026-08-18T17:54:01Z

Callkit does not allow to request a permission in the lock screen, we should probably request the permission when the user uses the app and we detect that the server has calls installed proactively and not on first use

Thanks @enahum. I wondered about that. It think what you'e proposed makes sense.

M-ZubairAhmed · 2026-08-19T06:21:10Z

@matthewbirtch

can you clarify this

Once connected to a DM call, I still see 'No one is talking'. That should be supressed. We should just show the avatar of the person you're on a call with and their name (without 'is talking').

…sibility cluster" This reverts commit 1382c93.

This reverts commit fde9237.

matthewbirtch · 2026-08-19T13:05:46Z

can you clarify this

Once connected to a DM call, I still see 'No one is talking'. That should be supressed. We should just show the avatar of the person you're on a call with and their name (without 'is talking').

Sure @M-ZubairAhmed. For the DM context, I was thinking that we could/should remove the 'No one is talking' state altogether. So when no one is actively speaking, we just show the avatar and name of the user you're on the call with. Like this:

If this is non-trivial, let me know. We could descope this for now if that's the case. Now that I think of it, we did not implement this in the webapp changes, so maybe it makes sense to defer this for now.

enahum

One more question: is it expected that joining a call takes me to the channel screen?

enahum · 2026-08-21T05:24:52Z

 import React, {forwardRef} from 'react';
 import Animated, {useAnimatedStyle, useDerivedValue, type SharedValue} from 'react-native-reanimated';

+import {type NavigationButtonProps} from '@components/navigation_button';


Nit: I see no reason for this change

enahum · 2026-08-21T05:25:38Z

 import {View} from 'react-native';

 import CompassIcon from '@components/compass_icon';
+import {type NavigationButtonProps} from '@components/navigation_button';


Same here, no reason

enahum · 2026-08-21T05:32:56Z

+    speakingUserStyle: StyleProp<TextStyle>;
+    speakingPostfixStyle: StyleProp<TextStyle>;


Why are we passing the styles as props and not defining them in the component?

enahum · 2026-08-21T05:57:22Z

+        distinctUntilChanged(),
+    );
+
+    // TODO: Remove startTime fallback


Anything to do here?

enahum · 2026-08-21T06:04:21Z

-            setIncomingCalls({...getIncomingCalls(), currentRingingCallId: undefined});
+            // The incoming ring and the outbound ringback share the one native player, so stop
+            // whichever is playing through its own owner
+            stopRingback();


So I place a call, send the app to the background, no ring back on my call?

I think this was defensive to prevent using the player which might be needed for ringtone. But, now that ringtones on iOS are always handled by CallKit, we can skip stopRingback on iOS and allow ringback tone in background.

If the app is still attempting to connect while backgrounded, then we should keep the outbound sound ringing.

enahum · 2026-08-21T06:05:21Z


-        const enabled = user.notifyProps?.calls_mobile_sound ? user.notifyProps.calls_mobile_sound === 'true' : user.notifyProps?.calls_desktop_sound === 'true';
-        if (!enabled) {
+        // No user shouldn't happen, so don't bother localizing and displaying an alert.


I don't understand this comment

enahum · 2026-08-21T06:06:59Z

+        const {database} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
+        const channel = await getChannelById(database, channelId);
+        if (!getDMCalleeId(currentCall.myUserId, channel)) {
+            logDebug('startRingbackIfNeeded skipped: not a 1:1 DM with someone else');


So for every non DM we get this log? Needed?

enahum · 2026-08-21T06:08:26Z

            nextCurrentCall.mySessionId = sessionId;
        }

+        // TODO: Since this is a synchronous event path, we should only set dmCalleeAnsweredAt for DM calls.


Anything to do here?

enahum · 2026-08-21T06:34:32Z

    /// registration failed and `didDeactivate` will never fire, this is the only
    /// teardown path.
    @objc public func resetSession() {
+        rtcSession.lockForConfiguration()


Why this change?

RTCAudioSession requires the configuration lock for its mutating calls

…e type imports for NavigationButtonProps

Added identifiers to test cases for the DM call button to improve traceability. The tests now include specific references to the associated ticket (MM-70370) for better tracking of changes related to the call button's visibility in different channel types.

Updated the CallStatusText component to utilize theme-based styles for speaking user and postfix text, improving consistency and maintainability. Removed unnecessary style props and integrated the styles directly within the component. Additionally, cleaned up imports in the current call bar and header components for better organization.

Removed outdated TODO comments regarding startTime fallback and DM call handling. Updated comments for clarity on user presence checks and the handling of dmCalleeAnsweredAt, ensuring consistency across call types. This enhances code readability and maintains focus on the intended functionality.

M-ZubairAhmed · 2026-08-24T11:51:44Z

/update-branch

M-ZubairAhmed · 2026-08-24T11:53:48Z

One more question: is it expected that joining a call takes me to the channel screen?

Yes thats for DM calls only

enahum · 2026-08-24T12:05:28Z

One more question: is it expected that joining a call takes me to the channel screen?

Yes thats for DM calls only

If that is the case, two follow up questions:

Does this work when answering the call through Callkit, with and without the phone locked

, is it also expected to be taken to the call screen for DM's when I return to the app when it was sitting in the background with an active call?

On iOS, CallKit owns the inbound ringtone and never uses the native audio player, so there is no shared-player conflict that would justify stopping ringback when the app backgrounds. Only stop ringback on background on Android, where inbound ring and ringback do share the one native MediaPlayer.

mm-cloud-bot added the release-note label Aug 6, 2026

M-ZubairAhmed force-pushed the dm-calls branch from e6a5692 to acf4b15 Compare August 6, 2026 17:06

mattermost-build added the E2E/Run Triggers E2E tests on both iOS and Android via Matterwick label Aug 7, 2026

bgardner8008 and others added 2 commits August 8, 2026 00:08

Mobile: single-click leave for non-hosts + remove end confirmation (#…

32d151f

…9987)

[MM-69767] Quick call button in the channel header (#9995)

3005544

M-ZubairAhmed force-pushed the dm-calls branch from c97c2a2 to 3005544 Compare August 7, 2026 18:38

mattermost-build added E2E/Run Triggers E2E tests on both iOS and Android via Matterwick and removed E2E/Run Triggers E2E tests on both iOS and Android via Matterwick labels Aug 7, 2026

mattermost-build removed the E2E/Run Triggers E2E tests on both iOS and Android via Matterwick label Aug 7, 2026

mattermost-build added E2E/Run Triggers E2E tests on both iOS and Android via Matterwick and removed E2E/Run Triggers E2E tests on both iOS and Android via Matterwick labels Aug 12, 2026

amyblais added this to the v2.44.0 milestone Aug 13, 2026

M-ZubairAhmed force-pushed the dm-calls branch from f9a7650 to af3870a Compare August 17, 2026 01:20

mattermost-build added the E2E/Run Triggers E2E tests on both iOS and Android via Matterwick label Aug 17, 2026

M-ZubairAhmed removed the E2E/Run Triggers E2E tests on both iOS and Android via Matterwick label Aug 17, 2026

mattermost-build added the E2E/Run Triggers E2E tests on both iOS and Android via Matterwick label Aug 17, 2026

mattermost-build removed the E2E/Run Triggers E2E tests on both iOS and Android via Matterwick label Aug 17, 2026

amyblais removed this from the v2.44.0 milestone Aug 17, 2026

bgardner8008 and others added 3 commits August 17, 2026 14:37

Mobile: single-click leave for non-hosts + remove end confirmation (#…

bcefc25

…9987)

[MM-69767] Quick call button in the channel header (#9995)

a85c965

[MM-69761][MM-70133][MM-70179] Auto-open full-screen call view on ini…

6136c99

…tiation and hide "People" button in 1:1 DM Call (#10031)

mattermost-build removed the E2E/Run Triggers E2E tests on both iOS and Android via Matterwick label Aug 18, 2026

M-ZubairAhmed added 2 commits August 19, 2026 12:22

Revert "test(e2e): quarantine 4 iOS Detox flakes from the hit-test/vi…

e57125e

…sibility cluster" This reverts commit 1382c93.

Revert "t1 for fullscreen bug"

978a4f8

This reverts commit fde9237.

mattermost-build added the E2E/Run Triggers E2E tests on both iOS and Android via Matterwick label Aug 19, 2026

M-ZubairAhmed requested review from enahum and removed request for carlisgg August 20, 2026 06:09

enahum requested changes Aug 21, 2026

View reviewed changes

M-ZubairAhmed added 4 commits August 24, 2026 17:08

Refactor imports in navigation header and agent chat components to us…

345fe0d

…e type imports for NavigationButtonProps

mattermost-build added E2E/Run Triggers E2E tests on both iOS and Android via Matterwick and removed E2E/Run Triggers E2E tests on both iOS and Android via Matterwick labels Aug 24, 2026

M-ZubairAhmed requested a review from enahum August 24, 2026 11:40

coderabbitai Bot approved these changes Aug 24, 2026

View reviewed changes

M-ZubairAhmed requested a review from matthewbirtch August 24, 2026 11:47

Merge branch 'main' into dm-calls

40d390e

mattermost-build added E2E/Run Triggers E2E tests on both iOS and Android via Matterwick and removed E2E/Run Triggers E2E tests on both iOS and Android via Matterwick labels Aug 24, 2026

mattermost-build removed the E2E/Run Triggers E2E tests on both iOS and Android via Matterwick label Aug 24, 2026

mattermost-build added E2E/Run Triggers E2E tests on both iOS and Android via Matterwick and removed E2E/Run Triggers E2E tests on both iOS and Android via Matterwick labels Aug 24, 2026

		speakingUserStyle: StyleProp<TextStyle>;
		speakingPostfixStyle: StyleProp<TextStyle>;

Uh oh!

Conversation

M-ZubairAhmed commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Ticket Link

Checklist

Device Information

Screenshots

Release Note

Uh oh!

M-ZubairAhmed commented Aug 6, 2026

Uh oh!

mattermost-build commented Aug 6, 2026

Uh oh!

M-ZubairAhmed commented Aug 7, 2026

Uh oh!

mattermost-build commented Aug 7, 2026

Uh oh!

github-actions Bot commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Comparison Report

Uh oh!

M-ZubairAhmed commented Aug 9, 2026

Uh oh!

mattermost-build commented Aug 9, 2026

Uh oh!

M-ZubairAhmed commented Aug 17, 2026

Uh oh!

mattermost-build commented Aug 17, 2026

Uh oh!

enahum commented Aug 18, 2026

Uh oh!

matthewbirtch commented Aug 18, 2026

Uh oh!

M-ZubairAhmed commented Aug 19, 2026

Uh oh!

matthewbirtch commented Aug 19, 2026

Uh oh!

enahum left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matthewbirtch Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

M-ZubairAhmed commented Aug 6, 2026 •

edited

Loading

github-actions Bot commented Aug 7, 2026 •

edited

Loading

matthewbirtch Aug 24, 2026 •

edited

Loading