Added the ability to send DMs from bot accounts#70
Closed
icelander wants to merge 3 commits into
Closed
Conversation
…ing to channels Signed-off-by: Paul Rothrock <paul@movetoiceland.com>
hanzei
added
2: Dev Review
jfrerich
suggested changes
Jun 29, 2021
jfrerich
left a comment
jfrerich
left a comment
Contributor
There was a problem hiding this comment.
Thanks @icelander! I have a couple of suggestions :)
mickmister
suggested changes
Jun 30, 2021
mickmister
left a comment
mickmister
left a comment
Contributor
There was a problem hiding this comment.
Nice work @icelander 👍 Implementation of the feature looks good
I have a request that goes along with Jason's comment above, to have the extracted function return an error so there is only one log statement for the error
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Contributor
|
Closing the PR due to the PR #129 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A customer had the requirement to send a DM from a bot account, so I added the ability. Any channel name that starts with an
@symbol that is also a bot user will have a DM sent with the message configured in the Action'sActionDirectMessagePost