Skip to content

[MM-387] Add a global welcome message field#131

Open
ayusht2810 wants to merge 4 commits into
masterfrom
MM-387
Open

[MM-387] Add a global welcome message field#131
ayusht2810 wants to merge 4 commits into
masterfrom
MM-387

Conversation

@ayusht2810

@ayusht2810 ayusht2810 commented Apr 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Added a global welcome message field
  • Updated Readme with the addition of new field

Screenshot

image

Checklist

  • Completed dev testing
  • make test Ran test cases and ensured they are passing
  • make check-style Ran style check and ensured both webapp and server pass the checks

Ticket Link

Fixes #36

What to test?

  • Add a new field GlobalWelcomeMessage in the welcome bot config
  • Create a new user and log in the Mattermost server from the new user
  • Check for the global message present in the welcome bot DM
  • Some edge cases to test: Add only GlobalWelcomeMessage in the config, add both TeamName and GlobalWelcomeMessage in the config

@ayusht2810
ayusht2810 requested a review from mickmister as a code owner April 17, 2024 10:27
@ayusht2810 ayusht2810 self-assigned this Apr 17, 2024
@ayusht2810 ayusht2810 added the 2: Dev Review Requires review by a core committer label Apr 17, 2024
@ayusht2810 ayusht2810 mentioned this pull request Apr 17, 2024
Closed
raghavaggarwal2308
raghavaggarwal2308 suggested changes Apr 29, 2024
View reviewed changes
Comment thread server/welcomebot.go Outdated
Comment thread server/hooks.go Outdated
mickmister
mickmister reviewed Jul 4, 2024
View reviewed changes

@mickmister mickmister left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall logic LGTM, just a few suggestions

Comment thread server/message_template.go Outdated
Comment thread server/welcomebot.go Outdated
Comment thread server/welcomebot.go Outdated
Comment thread server/hooks.go Outdated
Comment thread server/hooks.go Outdated
@mickmister mickmister added the 3: QA Review Requires review by a QA tester label Jul 4, 2024
@ayusht2810

ayusht2810 commented Jul 8, 2024

Copy link
Copy Markdown
Contributor Author

@mickmister Fixed the review fixes. Please re-review

@ayusht2810
ayusht2810 requested a review from mickmister July 8, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wiggin77 wiggin77 Awaiting requested review from wiggin77
2 more reviewers
@mickmister mickmister mickmister left review comments
@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

allow messages for *all* teams

3 participants

@ayusht2810 @mickmister @raghavaggarwal2308