[MM-382] Add feature to use struct fields in the channel welcome message#130
Open
ayusht2810 wants to merge 2 commits into
Open
[MM-382] Add feature to use struct fields in the channel welcome message#130ayusht2810 wants to merge 2 commits into
ayusht2810 wants to merge 2 commits into
Conversation
raghavaggarwal2308
suggested changes
Apr 29, 2024
mickmister
approved these changes
May 23, 2024
Comment on lines
+66
to
+76
| if len(channelID) > 0 { | ||
| data.Channel, err = p.API.GetChannel(channelID) | ||
| if err != nil { | ||
| p.API.LogError("failed to query channel", "ChannelID", channelID) | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| data.UserDisplayName = data.User.GetDisplayName(model.ShowNicknameFullName) | ||
|
|
||
| return data |
Contributor
There was a problem hiding this comment.
Is it the case that channelID will always be provided and non-empty? Is it the case that this function must return a fully populated ChannelMessageTemplate?
If that's the case, we should return an error if necessary passed in data is not available. Not sure about the situation here though
Contributor
Author
There was a problem hiding this comment.
No, it is not necessary to pass the channel ID here. Also, the function doesn't need to return a fully populated ChannelMessageTemplate.
raghavaggarwal2308
approved these changes
Jul 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshot
Ticket Link
Fixes #96
Fixes #55
What to test?
Checklist
make testRan test cases and ensured they are passingmake check-styleRan style check and ensured both webapp and server pass the checks