fix: remove stale @emotion/react mock from webapp unit tests#88
Merged
avasconcelos114 merged 1 commit intoJul 16, 2026
Merged
Conversation
Duplicates PR mattermost-community#87 so a maintainer with review permission can approve/merge it before the next release.
avasconcelos114
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicates #87 so a reviewer with merge permission can land the fix ahead of the next release.
Summary
After #84 (which added
webapp/src/index.test.js) and #86 (which removed@emotion/babel-preset-css-propand the unused@emotion/reactdep) both merged,npm teston master fails: the new test filejest.mocks@emotion/react, which no longer exists in the dependency graph. Both PRs' CI passed individually — the incompatibility only surfaced once both were on master.Fix: drop the now-unnecessary
jest.mock('@emotion/react', ...)block fromwebapp/src/index.test.js. Nothing in the code under test imports@emotion/react, so no replacement mock is needed.Test plan
npm testinwebapp/— all 3 suites / 10 tests pass locally