Skip to content

Adding the Mattermost Plugins E2E Utils as a dependency#258

Draft
panoramix360 wants to merge 5 commits into
mattermost-community:masterfrom
panoramix360:feature/integrate-e2e-utisl
Draft

Adding the Mattermost Plugins E2E Utils as a dependency#258
panoramix360 wants to merge 5 commits into
mattermost-community:masterfrom
panoramix360:feature/integrate-e2e-utisl

Conversation

@panoramix360

@panoramix360 panoramix360 commented May 31, 2024

Copy link
Copy Markdown

This PR is intended to test the integration with the Mattermost Plugins E2E Utils that I'm working on with @mickmister!

I'm creating as a draft for now, so we can test it.

Related PR in mattermost-plugin-e2e-test-utils repo
mattermost-community/mattermost-plugin-e2e-test-utils#3

Related thread
https://community.mattermost.com/core/pl/w4oistz7rtn4bj9ewfu8neimdh

@mickmister mickmister left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @panoramix360!! This is awesome that we're now connecting the dots between this repo and mattermost-community/mattermost-plugin-e2e-test-utils#3. This is going to be so awesome using this here! 🚀

Next steps here are to adapt the code in e2e/playwright folder that is related to the obsolete configuration:

Please let me know of any questions you may have, and if you feel a video call would be most efficient to discuss this. Thanks so much @panoramix360! Great job!!

Comment thread e2e/playwright/package.json Outdated
@mickmister

Copy link
Copy Markdown
Contributor

From my comment above:

Any functionality imported from @e2e-support/* should be relocated to the shared package.

I'm thinking a lot of this stuff is already in the shared package. If there's anything else that this @e2e-support import is providing, we can move it over to the shared package.

@hanzei hanzei added the Work In Progress Not yet ready for review label Jan 6, 2025
@panoramix360

panoramix360 commented Jan 7, 2025

Copy link
Copy Markdown
Author

hey @mickmister and @jespino! Happy new year!

Sorry for the delay on this, I'll resume working on that to try to implement this on the repo.

Let you know if I need any help, I was having an issue with the user_id when running the tests, I managed to solve a lot of problems already.

Thanks!

@panoramix360
panoramix360 force-pushed the feature/integrate-e2e-utisl branch from 46c38bb to 2aa5c91 Compare January 14, 2025 01:03
@panoramix360
panoramix360 force-pushed the feature/integrate-e2e-utisl branch from 2aa5c91 to b62af71 Compare January 14, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Work In Progress Not yet ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants