WIP: Playwright with shared repo, compared to open Playwright PR#235
Closed
mickmister wants to merge 6 commits into
Closed
WIP: Playwright with shared repo, compared to open Playwright PR#235mickmister wants to merge 6 commits into
mickmister wants to merge 6 commits into
Conversation
mickmister
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/adding-playwright-e2e #235 +/- ##
============================================================
Coverage ? 6.42%
============================================================
Files ? 11
Lines ? 1712
Branches ? 0
============================================================
Hits ? 110
Misses ? 1594
Partials ? 8 ☔ View full report in Codecov by Sentry. |
mickmister
changed the title
mickmister
marked this pull request as draft
November 20, 2023 02:15
Contributor
Author
|
Closing since #228 was merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is built off of Playwright PR #228, and is pointing to that branch for the sake of comparing the difference between them This PR uses a submodule defined at mattermost-community/mattermost-plugin-e2e-test-utils#1 to centralize the Playwright bootstrapping code.
PR comparing to master #236
Ticket Link