[MM-232] Update plugin with respect to phase 1 upgrades#72
Open
ayusht2810 wants to merge 2 commits into
Open
Conversation
hanzei
requested changes
Feb 20, 2024
hanzei
left a comment
hanzei
left a comment
Contributor
There was a problem hiding this comment.
Thanks for updating the plugin, a few questions below
Comment on lines
+40
to
+48
|
|
||
| ### Releasing new versions | ||
|
|
||
| The version of a plugin is determined at compile time, automatically populating a `version` field in the [plugin manifest](plugin.json): | ||
| * If the current commit matches a tag, the version will match after stripping any leading `v`, e.g. `1.3.1`. | ||
| * Otherwise, the version will combine the nearest tag with `git rev-parse --short HEAD`, e.g. `1.3.1+d06e53e1`. | ||
| * If there is no version tag, an empty version will be combined with the short hash, e.g. `0.0.0+76081421`. | ||
|
|
||
| To disable this behaviour, manually populate and maintain the `version` field. |
Contributor
There was a problem hiding this comment.
I think the README should clarify the practice used in this particular plugin.
Comment on lines
-7
to
-8
| "release_notes_url": "https://github.com/mattermost/mattermost-plugin-memes/releases/tag/v1.5.0", | ||
| "version": "1.5.0", |
Contributor
There was a problem hiding this comment.
Is there a consensus to use the auto-generated version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated plugin with respect to phase 1 upgrades
1.12to1.21buildfolder to sync with starter templateTicket Link