Additional metadata, Text Slot Rotation and Support for OTF fonts#58
Open
bladerail wants to merge 5 commits into
Open
Additional metadata, Text Slot Rotation and Support for OTF fonts#58bladerail wants to merge 5 commits into
bladerail wants to merge 5 commits into
Conversation
…t options, support for OTF fonts
bladerail
force-pushed
the
additional-metadata-and-otf-fonts
branch
3 times, most recently
from
March 30, 2022 18:07
5b35cc9 to
a8986a3
Compare
bladerail
force-pushed
the
additional-metadata-and-otf-fonts
branch
from
March 30, 2022 18:11
a8986a3 to
8ebaaa1
Compare
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 80.02% 79.70% -0.33%
==========================================
Files 3 3
Lines 1537 1606 +69
==========================================
+ Hits 1230 1280 +50
- Misses 184 192 +8
- Partials 123 134 +11
Continue to review full report at Codecov.
|
catalintomai
approved these changes
Aug 22, 2022
mickmister
approved these changes
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The gg image library also provides support for text wrapping and computing the size of the rectangle given the font face, allowing the removal of previous code which tried to compute the text for each line in the event that a text would need to stretch over to multiple lines.
I added the change-my-mind meme template to demo the text slot rotation. Set it to use the Zag OTF font for demonstration.
Updated this-is-fine because the black text over the fire was difficult to see.
Ticket Link
Addresses [#57] Additional metadata options, text rotation, support for Opentype fonts
Additional Remarks
First time working in GoLang. I was encountering some issues on the Master branch with regards to linting or
make check-style. Examplefieldalignment: struct with 136 pointer bytes could be 72 (govet). I needed to rearrange the fields to fix the field alignment errors brought up by Govet.I also noted that golint had been deprecated and replaced with revive. Do let me know if neither of these are desired.Edit: Found out why golint is still used over revive. Do let me know if the field rearrangment is an issue.