Skip to content

Undo behavior for auto-added table rows#5122

Open
bcmeireles wants to merge 3 commits into
mattermost-community:mainfrom
bcmeireles:issue-4849-table-undo-row
Open

Undo behavior for auto-added table rows#5122
bcmeireles wants to merge 3 commits into
mattermost-community:mainfrom
bcmeireles:issue-4849-table-undo-row

Conversation

@bcmeireles

Copy link
Copy Markdown

Summary

Fixes table-view row undo behavior for auto-added rows created after pressing Enter on the last row title.

This PR ensures:

  1. For a newly auto-added row with empty, untouched title:

    • Esc removes the row
    • Enter removes the row
    • Ctrl/Cmd+Z removes the row
  2. If the user typed in the new row title first:

    • Esc only cancels/reverts title editing behavior and does not remove the row
    • Ctrl/Cmd+Z removes the added row/card (undo at board level)

Fixes #4849

Manual Test Coverage

  • Create auto-added row via Enter on last row title.
  • Esc on untouched empty auto-added row removes it.
  • Enter on untouched empty auto-added row removes it.
  • Ctrl/Cmd+Z on untouched empty auto-added row removes it.
  • After typing in new row title, Esc does not remove the row.
  • After typing in new row title, Ctrl/Cmd+Z removes the added row.

@mattermost-build

Copy link
Copy Markdown
Contributor

Hello @bcmeireles,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

@bcmeireles

Copy link
Copy Markdown
Author

/check-cla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UX: Let users easily undo / remove auto-added table rows

2 participants