Undo behavior for auto-added table rows#5122
Conversation
|
Hello @bcmeireles, Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here. Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project. Please help complete the Mattermost contribution license agreement? This is a standard procedure for many open source projects. Please let us know if you have any questions. We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team. |
|
/check-cla |
Summary
Fixes table-view row undo behavior for auto-added rows created after pressing
Enteron the last row title.This PR ensures:
For a newly auto-added row with empty, untouched title:
Escremoves the rowEnterremoves the rowCtrl/Cmd+Zremoves the rowIf the user typed in the new row title first:
Esconly cancels/reverts title editing behavior and does not remove the rowCtrl/Cmd+Zremoves the added row/card (undo at board level)Fixes #4849
Manual Test Coverage
Enteron last row title.Escon untouched empty auto-added row removes it.Enteron untouched empty auto-added row removes it.Ctrl/Cmd+Zon untouched empty auto-added row removes it.Escdoes not remove the row.Ctrl/Cmd+Zremoves the added row.